Skip to content

[fix] Neo.FS, Neo deps#961

Open
cschuchardt88 wants to merge 4 commits intoneo-project:masterfrom
cschuchardt88:neo-node/update/vulnerable-deps
Open

[fix] Neo.FS, Neo deps#961
cschuchardt88 wants to merge 4 commits intoneo-project:masterfrom
cschuchardt88:neo-node/update/vulnerable-deps

Conversation

@cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jan 9, 2026

Description

Updated neo.fs with correct version of neo.fs and neo library deps for all plugins.

Change Log

  • Updated neo.fs library for oracleservices project
  • Updated Neo library in Directory.Build.props file

Required neo-project/neo#4424

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Testing
  • Run Application
  • Local Computer Tests
  • No Testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@erikzhang
Copy link
Member

Can you remove the whitespace changes?

@shargon
Copy link
Member

shargon commented Jan 9, 2026

Can you remove the whitespace changes?

Agree

erikzhang
erikzhang previously approved these changes Jan 10, 2026
shargon
shargon previously approved these changes Jan 10, 2026
@erikzhang
Copy link
Member

UT fails.

@shargon shargon dismissed their stale review January 10, 2026 09:29

UT fault

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Jan 11, 2026

Required neo-project/neo#4424 to fix this downstream repo

@superboyiii
Copy link
Member

superboyiii commented Jan 11, 2026

Hey @cschuchardt88 , good to see this. Can we just open another to master-n3 to fix the issue so we can release soon?

Wi1l-B0t
Wi1l-B0t previously approved these changes Jan 11, 2026
@ajara87
Copy link
Member

ajara87 commented Jan 13, 2026

Hey @cschuchardt88 , good to see this. Can we just open another to master-n3 to fix the issue so we can release soon?

ported on #964

Co-authored-by: Alvaro <amjarag@gmail.com>
@shargon shargon dismissed stale reviews from Wi1l-B0t and erikzhang via 74cae29 January 13, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants