Skip to content
This repository was archived by the owner on Sep 28, 2025. It is now read-only.

Conversation

@Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Apr 22, 2022

No description provided.

@shargon
Copy link
Member

shargon commented Apr 22, 2022

Could you describe the after and before?

@Jim8y
Copy link
Contributor Author

Jim8y commented Apr 22, 2022

Could you describe the after and before?

Currently we put all plugin.dll files under the same folder. Now we want to put plugin files in separate folder, for example, DBFTPlugin.dll under DBFTPlugin folder.

Bafore:

pluginA/config.json
pliginB/config.json
pluginA.dll
pluginB.dll

After:

pluginA/config.json
pluginA/plugnA.dll
pluginB/config.json
pluginB/pluginB.dll

@erikzhang
Copy link
Member

I don't think we need this change. We can just move the config.json file to the root folder.

@Jim8y
Copy link
Contributor Author

Jim8y commented Apr 22, 2022

I don't think we need this change. We can just move the config.json file to the root folder.

Either works, i just want to make the manually work as little as possible. i will keep this pr open until we have the whole task done.

@Jim8y Jim8y closed this Apr 23, 2022
@Jim8y Jim8y deleted the separate-plugin-folder branch June 25, 2022 02:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants