Fix ruTorrent utility functions #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, im using rutorrent-dock project https://github.com/nelu/rutorrent-dock for my local dev emv, with rutorrent setup in ./src/rutorrent |
nelu
reviewed
Jan 13, 2022
nelu
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The utility functions were recently changed in ruTorrent. Novik/ruTorrent#2247 They are no longer in the global scope. It's required to access these static methods from their respective classes now.
This PR is currently pending review to fix auto loading the utility classes from namespaces. Novik/ruTorrent#2253
I was not able to setup a testing environment conducive for this pull request. There might be more changes required.