Skip to content

feat: add a setting flag to control user pref lang #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johanseto wants to merge 2 commits into from
Closed

feat: add a setting flag to control user pref lang #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40322c6
feat: add a setting flag to control user pref lang
johanseto Jan 22, 2024
159ac19
feat: add pr suggestion logic
johanseto Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openedx/core/djangoapps/lang_pref/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ def process_request(self, request):
if LANGUAGE_SESSION_KEY in request.session and request.session[LANGUAGE_SESSION_KEY] != cookie_lang:
del request.session[LANGUAGE_SESSION_KEY]

# Apply language specified in SiteConfiguration, ignoring user preferences.
if language := get_value('LANGUAGE_CODE'):
# Apply language specified in SiteConfiguration, if there are not user preferences.
if (language := get_value('LANGUAGE_CODE')) and (not request.COOKIES.get(settings.LANGUAGE_COOKIE_NAME, None)):
request.COOKIES[settings.LANGUAGE_COOKIE_NAME] = language

def process_response(self, request, response): # lint-amnesty, pylint: disable=missing-function-docstring
Expand Down