feat: filter by current site organizations - #36
Merged
andrey-canon merged 1 commit intoAug 29, 2024
Conversation
andrey-canon
force-pushed
the
and/filter_result_by_current_orgs
branch
from
August 27, 2024 21:45
623f0cd to
da8ff07
Compare
johanseto
approved these changes
Aug 29, 2024
johanseto
left a comment
johanseto
left a comment
Collaborator
There was a problem hiding this comment.
It seems working. In only have some doubt related the count field one erollments because in the after shows me 0.
Also maybe is the difference from primary?
Before
After
Collaborator
|
I tested with other tenant and yes, seem it count after the primary course_enrollment. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Limit API result to current organizations
Testing instructions
/api/mobile/v4/users/<username>/course_enrollments/and check that the result doesn't contain any invalid organizationDeadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.