Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex tweaks #34

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Regex tweaks #34

merged 2 commits into from
Feb 15, 2019

Conversation

sosedoff
Copy link
Contributor

Made a few small changes to the git slug parsing:

  • Moved (and properly renamed) regular expressions into vars
  • Fixed failing test where github http regex was not matching https://github.com/user/repo without .git extension.

- No need to compile regexes in the function, moved them to vars
- Fixed github http regex: it was not matching https://github.com/foo/bar (no git extension)
Copy link
Contributor

@cplee cplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cplee cplee closed this Feb 15, 2019
@cplee cplee reopened this Feb 15, 2019
@cplee cplee merged commit 32c1ec9 into nektos:master Feb 15, 2019
makrsmark pushed a commit to makrsmark/act that referenced this pull request Aug 3, 2023
Fix https://gitea.com/gitea/act_runner/issues/80
Fix https://gitea.com/gitea/act_runner/issues/85

To support reusable workflows, I made some improvements:
- read `yml` files from both `.gitea/workflows` and `.github/workflows`
- clone repository for local reusable workflows because the runner doesn't have the code in its local directory
- fix the incorrect clone url like `https://https://gitea.com`

Co-authored-by: Jason Song <[email protected]>
Reviewed-on: https://gitea.com/gitea/act/pulls/34
Reviewed-by: Jason Song <[email protected]>
Co-authored-by: Zettat123 <[email protected]>
Co-committed-by: Zettat123 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants