Revised pin style #46
Conversation
These were originally included to provide UI consistency with the native counterpart MapKit. Although there were good intentions to present a consistent experience for the end user, I'm concerned this could be considered a violation of copyright so they need to be replaced.
Like the pins these need to be replaced. The title height was adjusted as it appeared off center with the new design.
Also removed note on using old version as this is no longer supported.
|
Check the build, it should succeed on Travis. Also update CHANGELOG. |
|
@dblock I'm unsure what is causing the build to fail, do you have any ideas? Tests pass locally. |
|
It's CocoaPods. 🎉 😦 |
|
Now the tests are failing because there are tests that are doing image-based comparisons of the output 😕 I have… feelings… about how useful tests of this nature are in small demo projects (or any projects). Personally, I'd pull them out and move on to more important tasks. |
This is not ideal, but I'm not sure how to fix the issues with the build server.
|
Thanks @tonyarnold. I think you're right and unfortunately I do not know enough about how the test setup works to fix this myself right now. I'll temporarily remove them for now. |
|
At a guess, it was probably because the tests are recorded on a 64 bit sim, and the tests are being ran on another device. But, YOLO. |
|
FWIW there was a lot of effort put into making snapshot tests work in this project and they catch real bugs, otherwise there's literally no way to know whether map annotations work at all. I opened #47. |
Switching to an original set of push pins graphics for NAPinAnnotation. The old ones were out of date anyway.
Tests have been updated too.