Yield429

.github/CODEOWNERS

@@ -92,7 +92,7 @@
 /sdk/ai/azure-ai-inference/                                        @dargilco @jhakulin @glharper @Azure/azure-java-sdk
 
 # PRLabel: %Voice Live
-/sdk/ai/azure-ai-voicelive/                                        @rhurey @xitzhang
+/sdk/ai/azure-ai-voicelive/                                        @rhurey @xitzhang @amber-yujueWang
 
 # ServiceLabel: %AKS
 # ServiceOwners:                                                   @Azure/aks-pm
@@ -918,7 +918,7 @@
 /common/perf-test-core/                                            @alzimmermsft @srnagar @g2vinay @Azure/azure-java-sdk
 
 # PRLabel: %common
-/.vscode/                                                          @alzimmermsft @srnagar @g2vinay @conniey @rujche @netyyyy @saragluna @moarychan @Azure/azure-java-sdk
+/.vscode/                                                          @alzimmermsft @srnagar @g2vinay @conniey @rujche @netyyyy @saragluna @moarychan @Azure/azure-java-sdk @raych1
 
 # ServiceLabel: %common
 # AzureSdkOwners:                                                  @alzimmermsft @srnagar

.vscode/cspell.json

@@ -873,7 +873,9 @@
       "words": [
         "Dexec",
         "viseme",
-        "VISEME"
+        "VISEME",
+        "webrtc",
+        "WEBRTC"
       ]
     },
     {

eng/.docsettings.yml

@@ -31,7 +31,6 @@ required_readme_sections:
   - ^Next steps$
   - ^Contributing$
 known_presence_issues:
-  - ['sdk/mediaservices/microsoft-azure-media', '#2847']
   - ['sdk/servicebus/microsoft-azure-servicebus', '#2847']
   # Changelog List
   - ['sdk/authorization/microsoft-azure-authentication-msi-token-provider/CHANGELOG.md', '#2847']
@@ -48,7 +47,6 @@ known_presence_issues:
   - ['sdk/keyvault/microsoft-azure-keyvault-extensions/CHANGELOG.md', '#2847']
   - ['sdk/keyvault/microsoft-azure-keyvault-webkey/CHANGELOG.md', '#2847']
   - ['sdk/keyvault/microsoft-azure-keyvault-test/CHANGELOG.md', '#2847']
-  - ['sdk/mediaservices/microsoft-azure-media/CHANGELOG.md', '#2847']
   - ['sdk/servicebus/microsoft-azure-servicebus/CHANGELOG.md', '#2847']
   - ['sdk/keyvault/microsoft-azure-keyvault-complete/CHANGELOG.md', '#2847']
 

eng/common/instructions/azsdk-tools/verify-setup.instructions.md

@@ -16,4 +16,4 @@ The user can specify multiple languages to check. If the user wants to check all
 ## Output
 Display results in a user-friendly and concise format, highlighting any missing dependencies that need to be addressed and how to resolve them.
 
-WHENEVER Python related requirements fail, ALWAYS ASK the user if they have set the `AZSDKTOOLS_PYTHON_VENV_PATH` system environment variable to their desired virtual environment. This tool can only check requirements in the venv path specified by that environment variable.
+When Python tool requirements fail, inform the user about the `AZSDKTOOLS_PYTHON_VENV_PATH` environment variable if they have setup issues. The verify-setup tool can only check Python requirements within the virtual environment specified by this environment variable.

eng/common/pipelines/templates/steps/create-apireview.yml

@@ -40,8 +40,9 @@ steps:
     - task: Powershell@2
       inputs:
         filePath: ${{ parameters.SourceRootPath }}/eng/common/scripts/Create-APIReview.ps1
+        # PackageInfoFiles example: @('a/file1.json','a/file2.json')
         arguments: >
-          -PackageInfoFiles ('${{ convertToJson(parameters.PackageInfoFiles) }}' | ConvertFrom-Json -NoEnumerate)
+          -PackageInfoFiles @('${{ join(''',''', parameters.PackageInfoFiles) }}')
           -ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name)
           -ArtifactPath '${{parameters.ArtifactPath}}'
           -ArtifactName ${{ parameters.ArtifactName }}

eng/common/pipelines/templates/steps/validate-all-packages.yml

@@ -24,6 +24,7 @@ steps:
         azureSubscription: opensource-api-connection
         scriptType: pscore
         scriptLocation: inlineScript
+        # PackageInfoFiles example: @('a/file1.json','a/file2.json')
         inlineScript: |
           $(Build.SourcesDirectory)/eng/common/scripts/Validate-All-Packages.ps1 `
             -ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name) `
@@ -34,7 +35,7 @@ steps:
             -BuildDefinition $(System.CollectionUri)$(System.TeamProject)/_build?definitionId=$(System.DefinitionId) `
             -PipelineUrl $(System.CollectionUri)$(System.TeamProject)/_build/results?buildId=$(Build.BuildId) `
             -IsReleaseBuild $$(SetAsReleaseBuild) `
-            -PackageInfoFiles ('${{ convertToJson(parameters.PackageInfoFiles) }}' | ConvertFrom-Json -NoEnumerate)
+            -PackageInfoFiles @('${{ join(''',''', parameters.PackageInfoFiles) }}')
         workingDirectory: $(Pipeline.Workspace)
       displayName: Validate packages and update work items
       continueOnError: true

eng/common/scripts/Create-APIReview.ps1

@@ -373,7 +373,8 @@ elseif ($ArtifactList -and $ArtifactList.Count -gt 0) {
 elseif ($PackageInfoFiles -and $PackageInfoFiles.Count -gt 0) {
     # Lowest Priority: Direct PackageInfoFiles (new method)
     Write-Host "Using PackageInfoFiles parameter with $($PackageInfoFiles.Count) files"
-    $ProcessedPackageInfoFiles = $PackageInfoFiles  # Use as-is
+    # Filter out empty strings or whitespace-only entries
+    $ProcessedPackageInfoFiles = @($PackageInfoFiles | Where-Object { -not [string]::IsNullOrWhiteSpace($_) })
 }
 else {
     Write-Error "No package information provided. Please provide either 'PackageName', 'ArtifactList', or 'PackageInfoFiles' parameters."
@@ -382,7 +383,7 @@ else {
 
 # Validate that we have package info files to process
 if (-not $ProcessedPackageInfoFiles -or $ProcessedPackageInfoFiles.Count -eq 0) {
-    Write-Error "No package info files found after processing parameters."
+    Write-Error "No package info files found after processing parameters. Or PackageInfoFiles parameter contains only empty or whitespace entries, please check the artifact settings."
     exit 1
 }
 

eng/common/scripts/Detect-Api-Changes.ps1

@@ -22,8 +22,16 @@ Param (
 $configFileDir = Join-Path -Path $ArtifactPath "PackageInfo"
 
 # Submit API review request and return status whether current revision is approved or pending or failed to create review
-function Submit-Request($filePath, $packageName, $packageType)
+function Submit-Request($filePath, $packageInfo)
 {
+    $packageName = $packageInfo.ArtifactName ?? $packageInfo.Name
+    $packageType = $packageInfo.SdkType
+
+    # Construct full package name with groupId if available
+    $fullPackageName = $packageName
+    if ($packageInfo.PSObject.Members.Name -contains "Group" -and $packageInfo.Group) {
+        $fullPackageName = "$($packageInfo.Group):$packageName"
+    }
     $repoName = $RepoFullName
     if (!$repoName) {
         $repoName = "azure/azure-sdk-for-$LanguageShort"
@@ -36,7 +44,7 @@ function Submit-Request($filePath, $packageName, $packageType)
     $query.Add('commitSha', $CommitSha)
     $query.Add('repoName', $repoName)
     $query.Add('pullRequestNumber', $PullRequestNumber)
-    $query.Add('packageName', $packageName)
+    $query.Add('packageName', $fullPackageName)
     $query.Add('language', $LanguageShort)
     $query.Add('project', $DevopsProject)
     $query.Add('packageType', $packageType)
@@ -75,7 +83,7 @@ function Submit-Request($filePath, $packageName, $packageType)
     catch
     {
         Write-Host "ERROR: API request failed" -ForegroundColor Red
-        Write-Host "Status Code: $($_.Exception.Response.StatusCode.Value__)" -ForegroundColor Yellow  
+        Write-Host "Status Code: $($_.Exception.Response.StatusCode.Value__)" -ForegroundColor Yellow
         Write-Host "Error: $($_.Exception.Message)" -ForegroundColor Yellow
         if ($_.ErrorDetails.Message) {
             Write-Host "Details: $($_.ErrorDetails.Message)" -ForegroundColor Yellow
@@ -165,7 +173,7 @@ foreach ($packageInfoFile in $packageInfoFiles)
         if ($isRequired -eq $True)
         {
             $filePath = $pkgPath.Replace($ArtifactPath , "").Replace("\", "/")
-            $respCode = Submit-Request -filePath $filePath -packageName $pkgArtifactName -packageType $packageType
+            $respCode = Submit-Request -filePath $filePath -packageInfo $packageInfo
             if ($respCode -ne '200')
             {
                 $responses[$pkgArtifactName] = $respCode

eng/common/scripts/Validate-All-Packages.ps1

@@ -278,16 +278,16 @@ if ($ArtifactList -and $ArtifactList.Count -gt 0)
         }
     }
 }
-elseif ($PackageInfoFiles -and $PackageInfoFiles.Count -gt 0)
-{
+elseif ($PackageInfoFiles -and $PackageInfoFiles.Count -gt 0) {
     # Direct PackageInfoFiles (new method)
     Write-Host "Using PackageInfoFiles parameter with $($PackageInfoFiles.Count) files"
-    $ProcessedPackageInfoFiles = $PackageInfoFiles
+    # Filter out empty strings or whitespace-only entries
+    $ProcessedPackageInfoFiles = @($PackageInfoFiles | Where-Object { -not [string]::IsNullOrWhiteSpace($_) })
 }
 
 # Validate that we have package info files to process
 if (-not $ProcessedPackageInfoFiles -or $ProcessedPackageInfoFiles.Count -eq 0) {
-    Write-Error "No package info files found after processing parameters."
+    Write-Error "No package info files found after processing parameters. Or PackageInfoFiles parameter contains only empty or whitespace entries, please check the artifact settings."
     exit 1
 }