Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding return type to methods #350

Merged
merged 4 commits into from
Oct 29, 2021
Merged

adding return type to methods #350

merged 4 commits into from
Oct 29, 2021

Conversation

chiragmahawar7
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Oct 24, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/negu3/meme-box/9hQiKuW8sxz6t8cL6qeL4mffRF1o
✅ Preview: https://meme-box-git-fork-chiragmahawar7-develop-negu3.vercel.app

negue
negue requested changes Oct 26, 2021
View reviewed changes
Copy link
Owner

@negue negue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , only 2 comments / changes but then this could be merged in. 👍

src/app/manage/media/media-overview/media-card/media-card.component.ts Outdated Show resolved Hide resolved
src/app/shared/dialogs/screen-arrange/drag-resize-media/drag-resize-media.component.ts Outdated Show resolved Hide resolved
@chiragmahawar7
Copy link
Contributor Author

LGTM , only 2 comments / changes but then this could be merged in. 👍

I have updated the PR

@negue
Copy link
Owner

negue commented Oct 29, 2021

Thank you for the contributions!

Would you like also to get added to the contributors list? :)

@negue negue merged commit 39966eb into negue:develop Oct 29, 2021
@chiragmahawar7
Copy link
Contributor Author

Thank you for the contributions!

Would you like also to get added to the contributors list? :)

Yeah sure.
I would try to look into more issues & enhancements.

@negue
Copy link
Owner

negue commented Oct 30, 2021

Awesome! There is a lot to fix so go ahead 👍 :)

@negue
Copy link
Owner

negue commented Oct 30, 2021

@all-contributors please add @chiragmahawar7 for code

@allcontributors allcontributors bot mentioned this pull request Oct 30, 2021
Merged
@allcontributors
Copy link
Contributor

@negue

I've put up a pull request to add @chiragmahawar7! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negue negue negue requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chiragmahawar7 @negue