Feature: "Easy" view for media files #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negue
reviewed
Mar 21, 2021
There was a problem hiding this comment.
Oh awesome!! 🎉
This will be a great addition to it.
The first time I opened I got a this.media.tags is undefined error.
I dunno if its because of that error but the items no break into rows (for example I have multiple images).
Guess no flex-wrap ?
Sorry for all the nagging here :D
Optional no need to do:
- Could you also make group panels sticky? that its visible during scroll.
- Center the other types icons in the card ?
src/app/manage/media/media-overview/media-overview.component.html
Outdated
Show resolved
Hide resolved
src/app/manage/media/media-overview/media-card/media-card.component.html
Show resolved
Hide resolved
|
Don't worry :) I fixed everything and added the optional stuff aswell. Hope you like it! Oh and I alseo replaced some of your static colors with a CSS Variable, that gets rid of a few TODOs :P |
|
Awesome!! the new UI looking gewd!! :) Thank you for the huge feature / UI overhaul^^ |
|
@all-contributors add @owehmer for bug and code |
|
I've put up a pull request to add @owehmer! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first step towards #85. This allows a new user to toggle between a cleaner, grouped view and the standard view. In the future we could use this to implement an actual pro view and maybe (?) get rid of the standard view.
This changes the default starting page to the easy view. We might want to change that until we have a proper "first time landing page"