Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/Suggestion: Dragging an object in the assign media view #250

Closed
owehmer opened this issue Apr 9, 2021 · 4 comments
Closed

Bug/Suggestion: Dragging an object in the assign media view #250

owehmer opened this issue Apr 9, 2021 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed open for contribution These issues can be done by contributors - otherwise I'll fix / add those my self :)
Milestone
2022.1

Comments

@owehmer
Copy link
Contributor

owehmer commented Apr 9, 2021

If you drag for example a picture to the far right or left the picture will shrink. You can't drag it partially out of the screen like it is the case if you drag it up or down.

I think this should be unified, either every side can be out of bounds or none..?
@negue
Copy link
Owner

negue commented Apr 9, 2021

Thats probably because of https://www.npmjs.com/package/moveable which prevents that

So I dont know if its even possible to improve it

@negue negue added bug Something isn't working help wanted Extra attention is needed open for contribution These issues can be done by contributors - otherwise I'll fix / add those my self :) labels Apr 9, 2021
@owehmer
Copy link
Contributor Author

owehmer commented Apr 9, 2021

Thats strange, but then you shouldn't be able to drag in out on the top/bottom right? How does it know that there are boundaries to the left and right?

@negue
Copy link
Owner

negue commented Apr 9, 2021

Thats exactly the question :D - I'll take a look at it maybe tomorrow maybe I can find something

@negue negue added this to the 2021.3 milestone May 18, 2021
@negue
Copy link
Owner

negue commented May 20, 2021

It seems to be now fixed?

Maybe because of your refactor? I dunno - its fixed 🎉

@negue negue closed this as completed May 20, 2021
negue added a commit that referenced this issue May 20, 2021
@negue
Arrange View: Moving Items out of screen-area - fixes #250
c4cf641
negue added a commit that referenced this issue May 20, 2021
@negue
Fixing lots of issues (#298)
443afce 
* Update installation.md

using @jonathanbucci great explanation about the port conflict

* extract cli options to own file + add media and open options

* improve docs

* trigger changedection of image selection - fixes #238

* prevent minus values on screentime - fixes #2398

* changing any settings would result into refresh the target screen (including all media) - fixes #284

* fix multiline widget variables - fixes #291

* fix change position style - now also adds a size - fixes #253

* Arrange View: Moving Items out of screen-area - fixes #250

* fix ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed open for contribution These issues can be done by contributors - otherwise I'll fix / add those my self :)
Projects
None yet
Milestone
2022.1
Development

No branches or pull requests
2 participants
@negue @owehmer