Repository navigation
http-transport: restore explicit credentialed origin reflection - #277
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughCORS configuration now permits credentials with reflected origins. Runtime handling preserves explicit credential settings for object and function configurations, and tests cover response headers and TypeScript configuration validity. ChangesCORS credential reflection
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cors: truedefaultallowCredentialsvalues at runtimeWhy
PR #270 intentionally stopped
cors: truefrom reflecting arbitrary origins with credentials. Neem planners cannot use the callback alternative because functions are not structured-cloneable, leaving no way to opt into the former behavior through planner data.This adds the explicit serializable alternative:
This addresses the old-behavior use case from #276 without changing the safe default. Functional planner options remain a separate worker-boundary concern.
Validation
vp test run packages/http-transport/tests/cors.spec.ts --reporter=agentvp exec oxlint packages/http-transport/src packages/http-transport/tests --format=agentSummary by CodeRabbit
Bug Fixes
Access-Control-Allow-Credentialsheader.Improvements