Only include the required output in ps #69
Conversation
|
Another attempt to fix #62. Only tested on mac. |
|
Removed the [] because with it in place, I got the following:
|
|
See also #64 |
|
Seems like the output is not being properly parsed by table-parser |
|
Fixing this required making a fix to table-parser: neekey/table-parser#12 |
|
Mac build delays on Travis, fyi: https://www.traviscistatus.com/incidents/mc9x2wmpnvhg |
|
@Empact Hi, you can now use [email protected] Can you try using the new version of table-parser first instead of change the default |
On mac, lx includes: -l Display information associated with the following keywords: uid, pid, ppid, flags, cpu, pri, nice, vsz=SZ, rss, wchan, state=S, paddr=ADDR, tty, time, and command=CMD. On mac, the ps output can be misaligned, e.g. when some VSZ field is longer than expected. VSZ and many others of these fields are unnecessary because we're looking up by name, pid, ppid, or arguments only. Here I select those directly. This requires neekey/table-parser#12 which was released in table-parser 1.0.0+
|
@neekey rebased and updated dependency 👍 |
|
@Empact can you revert the change of |
|
Gotcha, yeah will get to that this weekend.
…On Sat, Apr 7, 2018 at 18:18 Neekey ***@***.***> wrote:
@Empact <https://github.com/Empact> can you revert the change of var
exeArgs = query.psargs || ['lx']; to see if it works for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#69 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAVXng-35exWF_cn6sbCvm2le4n5HW8ks5tmWVLgaJpZM4RMLya>
.
|
|
@neekey Can confirm that this does not work without the change to Agree we need to test for impact against linux. FWIW ubuntu man page is consistent with this use: http://manpages.ubuntu.com/manpages/xenial/man1/ps.1.html |
|
@neekey Thoughts on this? |
On mac,
ps lincludes:On mac, the ps output can be misaligned, e.g. when some VSZ field is
longer than expected.
VSZ and many others of these fields are unnecessary because we're looking
up by name, pid, ppid, or arguments only. Here I select those directly.