Fix whitespace token issue with newer flair versions #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can now remove the upper bound on the flair version
jantrienes
added a commit
that referenced
this pull request
Oct 13, 2020
This is necessary to align with the changes in #28.
jantrienes
added a commit
that referenced
this pull request
Oct 13, 2020
This is necessary to align with the changes in #28.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With flair>=0.5, whitespace tokens are ignored when constructing sentences (flair code).
To make round-trips from standoff -> token -> standoff possible, those tokens need to be retained. As a fix, we previously added an upper bound on the flair version (#20). However, this prevents us from upgrading to newer flair versions.
In this PR, we update sentence construction such that whitespace-only tokens are replaced with a special token.
Furthermore, the upper bound on the flair version can now be removed.