Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace token issue with newer flair versions #28

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

jantrienes
Copy link
Collaborator

With flair>=0.5, whitespace tokens are ignored when constructing sentences (flair code).

To make round-trips from standoff -> token -> standoff possible, those tokens need to be retained. As a fix, we previously added an upper bound on the flair version (#20). However, this prevents us from upgrading to newer flair versions.

In this PR, we update sentence construction such that whitespace-only tokens are replaced with a special token.
Furthermore, the upper bound on the flair version can now be removed.

@jantrienes jantrienes merged commit 720216e into master Sep 4, 2020
@jantrienes jantrienes deleted the upgrade-flair branch September 4, 2020 12:46
jantrienes added a commit that referenced this pull request Oct 13, 2020
This is necessary to align with the changes in #28.
jantrienes added a commit that referenced this pull request Oct 13, 2020
This is necessary to align with the changes in #28.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant