Gracefully handle surrogate replacement for shuffle without choices #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For tags without a special surrogate generator, we shuffle annotations across the entire corpus. To prevent an annotation from remaining in the original document, we exclude the annotation from the set of choices. This strategy breaks when an annotation is unique in the corpus. This commit fixes the issue by falling back to the IdentityGenerator when `choices` are empty. A warning is raised to the user.
thomasmarkus
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tags without a special surrogate generator, we shuffle annotations across the entire corpus. To prevent an annotation from remaining in the original document, we exclude the annotation from the set of choices. This strategy breaks when an annotation is unique in the corpus. This commit fixes the issue by falling back to the IdentityGenerator when
choicesare empty. A warning is raised to the user.