-
Notifications
You must be signed in to change notification settings - Fork 25
Replace gsl-lite with span-lite #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BurningEnlightenment
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some minor nits, but we'll need to wait for Niall's approval.
|
I pretty much agree with @BurningEnlightenment's feedback. Thanks for the PR! |
|
@BurningEnlightenment Will this need some changes to the vcpkg port? |
|
Yeah, I'll take care of that. Will probably take a few days due to the review process, etc. |
|
thanks ! :) |
This was an oversight in #29
|
I fixed a minor build system issue and opened microsoft/vcpkg#25560 |
|
https://github.com/ned14/outcome/runs/7141879761?check_suite_focus=true suggests this PR broke Outcome CI? |
|
I will take a look in an hour or so. |
This looks like an issue I already encountered while updating the vcpkg port (not #32). I pushed 9cdcd45 onto the master branch to fix it. So the CI should be green again next time. |
For #28