Grcuda 132 refactor deviceselectionpolicy in grcudastreampolicy #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-ofgod
reviewed
Nov 2, 2022
ian-ofgod
reviewed
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes that extend DeviceSelectionPolicy have been detached from GrCUDAStreamPolicy and now they are in standalone files. retrieve and retrieveImpl methods have been modified in order to call retrieve from other classes, then fallback to the parent class DeviceSelectionPolicy and finally call the right retrieveImpl on the child class. Now TransferTimeDeviceSelectionPolicy extends DeciceSelectionPolicy instead of MinimizeTransferSizeDeviceSelectionPolicy for better logical abstraction