Remove opinionated cursor styles on buttons#563
Merged
jonathantneal merged 1 commit intomasterfrom Mar 30, 2016
Merged
Conversation
|
LGTM |
|
Hey, it can break a lot of styles. I always expect clickable button like link. |
|
LGTM! |
Contributor
Author
|
@TrySound, please see #371 (comment) |
This was referenced Jul 6, 2016
aduth
added a commit
to 18F/identity-idp
that referenced
this pull request
Dec 29, 2020
**Why**: Upgrading from `identity-style-guide` 2.2.3 to 3.0.0 involves upgrading from `uswds` 2.0.3 to 2.9.0 which involves upgrading from `normalize.css` 3.0.3 to 8.0.1. In `normalize.css` 4.1.0, opinionated button cursor styles were removed, and must be manually applied where desired. See: - necolas/normalize.css#563 - https://github.com/necolas/normalize.css/blob/master/CHANGELOG.md#410-april-11-2016 - uswds/uswds#3215
aduth
added a commit
to 18F/identity-idp
that referenced
this pull request
Jan 4, 2021
* Restore pointer cursor to selfie capture overlay "button" **Why**: Upgrading from `identity-style-guide` 2.2.3 to 3.0.0 involves upgrading from `uswds` 2.0.3 to 2.9.0 which involves upgrading from `normalize.css` 3.0.3 to 8.0.1. In `normalize.css` 4.1.0, opinionated button cursor styles were removed, and must be manually applied where desired. See: - necolas/normalize.css#563 - https://github.com/necolas/normalize.css/blob/master/CHANGELOG.md#410-april-11-2016 - uswds/uswds#3215 * Order CSS properties * Order CSS properties, for real
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #544 and #371