[pull] main from solidusio:main #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This allows us to keep the backend controllers out of the autoloaded `app` directory, which in turn allows us to ditch the direct dependency on solidus_backend. We do, however, load it still, just ignore it if it's not available.
Initializing the app with the code prior to this commit would instantiate the promotions configuration, which is not good because instantiating it via `Spree::Config.promotions` leads to the object being instacached and very, very hard to change. Also, we currently have to spots in the app where we can configure the promotion api attributes, and this reduces it to just one by deprecating the preference :promotion_attributes on `Spree::ApiConfiguration`.
display_number is used by many partials and templates displaying the payment source identifier to users or admins. StoreCredit was missing this metho, leading to errors if a store credit is used as payment source.
…ject-on-startup Do not initialize promotions object on startup
Move promotion backend controllers to `lib/
fix(StoreCredit): Add display_number method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )