Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run code in else block if ruby tag is standalone #53

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Run code in else block if ruby tag is standalone #53

merged 2 commits into from
Jun 24, 2024

Conversation

IbraheemTuffaha
Copy link
Contributor

This fixes the bug described in this issue #51 opened by @AliOsm
The problem is that some tags are standalone, with no body or end tags
Like yield and next statements
This PR runs the same code written in the else block of the switch statement if the tags are standalone

@IbraheemTuffaha
Copy link
Contributor Author

@elia

@lakim lakim mentioned this pull request Jun 23, 2024
@elia
Copy link
Member

elia commented Jun 24, 2024

@IbraheemTuffaha thanks for fixing this!
I added some fixtures to avoid regressions.

@elia elia merged commit d23c1c0 into nebulab:main Jun 24, 2024
5 checks passed
@IbraheemTuffaha IbraheemTuffaha deleted the fix-standalone-erb-tags branch June 24, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants