Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and solve envs using mamba #915

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Create and solve envs using mamba #915

merged 1 commit into from
Nov 12, 2021

Conversation

iameskild
Copy link
Member

Changes:

  • This PR will add mamba to the QHub docker images, which will speed up the image build times considerably
  • To reduce the complexity of Add support for CentOS #904, I will be breaking it up into smaller PRs

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iameskild thank you for these changes and splitting this into a PR that is easier to review 😄 . I've ran these locally as well as looked at the docker image builds on CI. Looks to build the jupyterlab image 4X faster along with many others building faster as well. Thanks!

@costrouc costrouc merged commit 47a42b8 into main Nov 12, 2021
@costrouc costrouc deleted the mamba_build branch November 12, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants