Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qhub-config.yaml as a secret #905

Merged
merged 3 commits into from
Nov 16, 2021
Merged

qhub-config.yaml as a secret #905

merged 3 commits into from
Nov 16, 2021

Conversation

danlester
Copy link
Contributor

@danlester danlester commented Nov 5, 2021

Closes #902

Please remove anything marked as optional that you don't need to fill in. Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666). If there is no issue, remove the line. Remove this note after reading.

Changes:

Adds qhub-config-yaml secret containing a copy of the YAML file. Also mounts it on extension pods (optionally)

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • [x ] No

In case you checked yes, did you write tests?

  • Yes
  • No

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@danlester danlester merged commit 1e86d99 into main Nov 16, 2021
@danlester danlester deleted the yamlconfigmap branch November 26, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make qhub-config.yaml contents available within Kubernetes [enhancement]
1 participant