Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in KubernetesCredentials #2729

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

blakerosenthal
Copy link
Contributor

Reference Issues or PRs

Fixes typo and removes typos: ignore from src/_nebari/stages/infrastructure/__init__.py as described in #2597.

I verified that no additional changes are needed for the upgrade step since this pydantic model is only used as an output.

Fixes #2597

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

Copy link
Member

@Adam-D-Lewis Adam-D-Lewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Adam-D-Lewis Adam-D-Lewis merged commit eaa415e into nebari-dev:develop Oct 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

Handle cluster_ca_certifiate typo in upgrade step
2 participants