Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in permissions boundary to k8s module #2153

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

aktech
Copy link
Member

@aktech aktech commented Dec 18, 2023

The permissions boundary was not passed in properly, as a result you'd see AccessDenied exception, when creating roles without the given permissions boundary.

Reference Issues or PRs

Fixes #2152

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@costrouc
Copy link
Member

@aktech would you mind adding to this PR how exactly one would set the permissions_boundary setting

@costrouc costrouc self-requested a review December 19, 2023 15:42
@aktech
Copy link
Member Author

aktech commented Jan 8, 2024

@pavithraes pavithraes added this to the 2024.1.1 milestone Jan 9, 2024
@dcmcand dcmcand merged commit 507d1ae into develop Jan 9, 2024
27 checks passed
@dcmcand dcmcand deleted the permissions-boundary-fix branch January 9, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] - Permissions boundary not passed in correctly
4 participants