Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add test coverage #1959

Merged
merged 7 commits into from
Aug 31, 2023
Merged

CI: Add test coverage #1959

merged 7 commits into from
Aug 31, 2023

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Aug 29, 2023 •
edited by iameskild
Loading

Reference Issues or PRs

Closes #1956

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@pavithraes pavithraes added type: enhancement 💅🏼 New feature or request status: in progress 🏗 This task is currently being worked on needs: tests ✅ This contribution is missing tests labels Aug 29, 2023
@fangchenli fangchenli marked this pull request as ready for review August 31, 2023 14:18
@iameskild iameskild self-requested a review August 31, 2023 15:31
iameskild
iameskild approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @fangchenli!!

@iameskild iameskild removed the status: in progress 🏗 This task is currently being worked on label Aug 31, 2023
@iameskild iameskild merged commit f4ab2ac into nebari-dev:develop Aug 31, 2023
9 checks passed
@fangchenli fangchenli deleted the codecov branch August 31, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild iameskild approved these changes

Assignees
No one assigned
Labels
needs: tests ✅ This contribution is missing tests type: enhancement 💅🏼 New feature or request
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] - Add Codecov
3 participants
@fangchenli @iameskild @pavithraes