Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try and add argo envs when disabled #1926

Merged
merged 10 commits into from
Sep 11, 2023
Merged

Do not try and add argo envs when disabled #1926

merged 10 commits into from
Sep 11, 2023

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

Fixes #1904

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild requested a review from a team August 21, 2023 17:57
@pavithraes pavithraes added the needs: review 👀 This PR is complete and ready for reviewing label Aug 29, 2023
@iameskild iameskild added this to the Release 2023.9.1 milestone Aug 29, 2023
@kenafoster
Copy link
Contributor

I tested this with the following steps:

  1. Starting with an existing Nebari deployment with no argo-workflows config specified (and therefore enabled by default), I confirmed JLab launches OK and includes argo vars
  2. I updated my nebari config to disable argo workflows, deployed successfully, and confirmed launching JLab now fails, reproducing the error reported in the bug
  3. Checked out branch fix-1904, re-ran nebari deploy successfully (same disabled workflows config), and now JLab launches successfully
  4. Also in a JLab terminal, env | grep ARGO now shows nothing

@iameskild
Copy link
Member Author

Thanks a bunch @kenafoster!!

@pavithraes @kcpevey could you please review and approve when you get a chance? Thank you

Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @iameskild and @kenafoster! ✨

@pavithraes pavithraes added status: approved 💪🏾 This PR has been reviewed and approved for merge and removed needs: review 👀 This PR is complete and ready for reviewing labels Sep 11, 2023
@pavithraes pavithraes merged commit f5da3c2 into develop Sep 11, 2023
25 checks passed
@pavithraes pavithraes deleted the fix-1904 branch September 11, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: integration/Argo status: approved 💪🏾 This PR has been reviewed and approved for merge
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] - Jupyter servers fail to start with Argo Workflows disabled
4 participants