Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Remove aws cli, use boto3 #1920

Merged
merged 5 commits into from
Aug 17, 2023
Merged

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Aug 17, 2023

Reference Issues or PRs

close #1917

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

check_credentials is called before those functions, so the AWS_DEFAULT_REGION environment variable is always available when boto3 client is initialized.

@fangchenli fangchenli changed the title Remove aws cli ENH: Remove aws cli, use boto3 Aug 17, 2023
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work jumping in and adding this enhancement! Thanks @fangchenli

@iameskild iameskild merged commit 0a1c778 into nebari-dev:develop Aug 17, 2023
8 checks passed
@fangchenli fangchenli deleted the remove-aws-cli branch August 18, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[ENH] - Remove AWS CLI dependency from Nebari
2 participants