Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import path in deployment tests & misc #1908

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Conversation

aktech
Copy link
Member

@aktech aktech commented Aug 14, 2023

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@aktech aktech changed the title Fix import path in deployment tests Fix import path in deployment tests & misc Aug 14, 2023
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

As a side note, I will aim to get #1856 (which handles the k8s upgrade) merged this week as well.

@aktech aktech merged commit f46a63f into develop Aug 14, 2023
25 checks passed
@aktech aktech deleted the fix-deployment-test-path branch August 14, 2023 15:43
@aktech
Copy link
Member Author

aktech commented Aug 14, 2023

As a side note, I will aim to get #1856 (which handles the k8s upgrade) merged this week as well.

Thanks, looks like an important PR, would be nice to get that one in. 🙌

@iameskild iameskild mentioned this pull request Aug 14, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants