Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upgrade command in preparation for release #1868

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Update upgrade command in preparation for release #1868

merged 2 commits into from
Jul 21, 2023

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

This PR updates the nebari upgrade command to improve the UI and to fix the "image update" functions. Lastly, I updated the versions for nebari-dask, all the docker images and the nebari-workflow-controller.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

costrouc
costrouc reviewed Jul 21, 2023
View reviewed changes
src/_nebari/upgrade.py Outdated Show resolved Hide resolved
costrouc
costrouc reviewed Jul 21, 2023
View reviewed changes
src/_nebari/upgrade.py

rich.print("\n ⚠️ Deprecation Warnings ⚠️")
rich.print(
f"-> [green]{self.version}[/green] is the last Nebari version that supports CDS Dashboards"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this to the notes.

costrouc
costrouc approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And thanks for making the messaging better than it was before.

aktech
aktech reviewed Jul 21, 2023
View reviewed changes
src/_nebari/upgrade.py Outdated Show resolved Hide resolved
@iameskild iameskild merged commit b90c5a7 into develop Jul 21, 2023
25 checks passed
@iameskild iameskild deleted the update_upgrade branch July 21, 2023 21:32
@iameskild iameskild mentioned this pull request Jul 21, 2023
Closed
18 tasks
costrouc added a commit that referenced this pull request Aug 3, 2023
@costrouc
Changes to account for #1832 and #1868
aa6a93b
iameskild pushed a commit that referenced this pull request Aug 9, 2023
@costrouc @iameskild
Changes to account for #1832 and #1868
142182c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aktech aktech aktech left review comments

@costrouc costrouc costrouc approved these changes

Assignees
No one assigned
Labels
area: dependencies 📦 All things dependencies area: nebari-cli area: user experience 👩🏻‍💻
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iameskild @costrouc @aktech