-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework for Nebari deployment via pytest for extensive testing #1867
Conversation
Reminder for @costrouc and @iameskild to test this as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work @aktech!
Given that this will be used to deploy cloud-based Nebari clusters, will this replace some of the manual setup we do for the integration tests? That's what I recall from our previous conversation with @costrouc.
Lastly, I'm unfortunately unable to test this locally because Digital Ocean just dropped support for kubernetes 1.24...
@aktech the one other thing that will likely be worthwhile adding is some sort of clean up script so in the event things are fully destroyed, we can still ensure the cloud resources are removed. We have a script for AWS (python and bash) but for the other cloud providers, we can either copy over what we have from the integration tests or write a python script that handles this for us. |
@iameskild makes sense about the clean up script. How do you feel about I tackle that in a follow up PR? we're not going to be running the integration tests on each push at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aktech this looks good to me! As we discussed offline, we can open new PRs for any fixes or updates. Thanks again 🎉
Part of fixing #1862
This creates a framework to write tests that are designed to test things on Nebari deployed on cloud. At the moment it only deploys on DigitalOcean, which can be easily expanded to all other clouds.
It would be better to merge this small chunk and then work on other cloud providers, rather than a single PR handling all clouds making it difficult to review.
Testing on cloud would be simply adding the decorator
@on_cloud("cloud_name")
:Other Fixes:
Notes:
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?