-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unvendor keycloak_metrics_spi #1810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New implementation is a lot simpler, thanks Adam! Good to merge if CI is green.
then | ||
echo "Error: Checksum not verified" && exit 1 | ||
else | ||
chown 1000:1000 /data/keycloak-metrics-spi-2.5.3.jar && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an artifact from the previous implementation that had this and the next line on one line.
chown 1000:1000 /data/keycloak-metrics-spi-2.5.3.jar && | |
chown 1000:1000 /data/keycloak-metrics-spi-2.5.3.jar |
if ! (echo "$SHA256SUM /data/keycloak-metrics-spi-2.5.3.jar" | sha256sum -c) | ||
then | ||
echo "Error: Checksum not verified" && exit 1 | ||
else | ||
chown 1000:1000 /data/keycloak-metrics-spi-2.5.3.jar && | ||
chmod 777 /data/keycloak-metrics-spi-2.5.3.jar | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: formatting looks a little off
if ! (echo "$SHA256SUM /data/keycloak-metrics-spi-2.5.3.jar" | sha256sum -c) | |
then | |
echo "Error: Checksum not verified" && exit 1 | |
else | |
chown 1000:1000 /data/keycloak-metrics-spi-2.5.3.jar && | |
chmod 777 /data/keycloak-metrics-spi-2.5.3.jar | |
fi | |
if ! (echo "$SHA256SUM /data/keycloak-metrics-spi-2.5.3.jar" | sha256sum -c); then | |
echo "Error: Checksum not verified" && exit 1 | |
else | |
chown 1000:1000 /data/keycloak-metrics-spi-2.5.3.jar && | |
chmod 777 /data/keycloak-metrics-spi-2.5.3.jar | |
fi |
Reference Issues or PRs
Closes #1805
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?