Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH action typos #1677

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Fix GH action typos #1677

merged 1 commit into from
Mar 14, 2023

Conversation

kcpevey
Copy link
Contributor

@kcpevey kcpevey commented Mar 10, 2023

This is a quick fix for a typo in the gh action. The path trigger for pyproject.toml was listed as pyproject.yoml.

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@kcpevey kcpevey requested a review from iameskild March 10, 2023 14:24
iameskild
iameskild approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ;)

@iameskild iameskild added this to the Release 2023.3.1 milestone Mar 14, 2023
@trallard
Copy link
Member

is this ready for merge? if so can either @kcpevey or @iameskild merge?

@pavithraes pavithraes added type: maintenance 🛠 Day-to-day maintenance tasks status: approved 💪🏾 This PR has been reviewed and approved for merge labels Mar 14, 2023
@trallard trallard merged commit fd6fb64 into develop Mar 14, 2023
@trallard trallard deleted the fix_gh_action_typo branch March 14, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild iameskild approved these changes

Assignees
No one assigned
Labels
status: approved 💪🏾 This PR has been reviewed and approved for merge type: maintenance 🛠 Day-to-day maintenance tasks
Projects
🪴 Nebari Project Management
Archived in project
Milestone
Release 2023.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@kcpevey @trallard @iameskild @pavithraes