Name change QHub --> Nebari #1508

iameskild · 2022-10-25T14:10:50Z

Fixes | Closes | Resolves #

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Closes #1508

Changes introduced in this PR:

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds a feature)
Breaking change (fix or feature that would cause existing features to not work as expected)
Documentation Update
Code style update (formatting, renaming)
Refactoring (no functional changes, no API changes)
Build related changes
Other (please describe):

Testing

Requires testing

Yes
No

In case you checked yes, did you write tests?

Yes
No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

Yes, docstrings
Yes, main documentation
Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

review-notebook-app · 2022-10-25T14:10:56Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

viniciusdc · 2022-10-25T14:19:47Z

Thanks, @iameskild !!!

github-actions · 2022-10-25T14:21:21Z

💰 Infracost estimate: monthly cost will not change

Project	Previous	New	Diff
All projects	$73.00	$73.00	$0

9 projects have no cost estimate changes.

Infracost output

──────────────────────────────────

The following projects have no cost estimate changes: Quansight/qhub/data/stages/01-terraform-state/gcp (Module path: 01-terraform-state/gcp), Quansight/qhub/data/stages/02-infrastructure/gcp (Module path: 02-infrastructure/gcp), Quansight/qhub/data/stages/03-kubernetes-initialize (Module path: 03-kubernetes-initialize), Quansight/qhub/data/stages/04-kubernetes-ingress (Module path: 04-kubernetes-ingress), Quansight/qhub/data/stages/05-kubernetes-keycloak (Module path: 05-kubernetes-keycloak), Quansight/qhub/data/stages/06-kubernetes-keycloak-configuration (Module path: 06-kubernetes-keycloak-configuration), Quansight/qhub/data/stages/07-kubernetes-services (Module path: 07-kubernetes-services), Quansight/qhub/data/stages/08-nebari-tf-extensions (Module path: 08-nebari-tf-extensions), Quansight/qhub/data/stages/08-qhub-tf-extensions (Module path: 08-qhub-tf-extensions)
Run the following command to see their breakdown: infracost breakdown --path=/path/to/code

──────────────────────────────────
4 cloud resources were detected:
∙ 4 were estimated, all of which include usage-based costs, see https://infracost.io/usage-file

This comment will be updated when the cost estimate changes.

_{Is this comment useful? Yes, No, Other}

viniciusdc · 2022-10-25T17:57:14Z

@iameskild, thanks for fixing the upgrade tests! 😄 @trallard for now, we will keep the mentions of qhub in there, as it's heavily used by the upgrade command. We will need to open a PR/issue to address the upgrade mechanic after the migration.

I was working on this to ship together with the migration, but there are some bits that will require more attention

trallard · 2022-10-25T18:36:05Z

Also, we need to start testing for Python 3.11

.github/ISSUE_TEMPLATE/release-checklist.md

.github/workflows/infracost.yml

.github/workflows/test.yaml

README.md

nebari/deploy.py

nebari/initialize.py

Co-authored-by: Tania Allard <[email protected]>

…riables.tf Co-authored-by: Tania Allard <[email protected]>

…es/forwardauth/variables.tf Co-authored-by: Tania Allard <[email protected]>

Co-authored-by: Tania Allard <[email protected]>

nebari/constants.py

Co-authored-by: Tania Allard <[email protected]>

Co-authored-by: Vinicius D. Cerutti <[email protected]>

Co-authored-by: Tania Allard <[email protected]>

iameskild · 2022-10-26T11:51:33Z

There are several missed replacements, including URLs, capitalisation, references and images.

@iameskild and @viniciusdc please make sure to go over and find any missed changes

Thanks for the review @trallard!! As @viniciusdc pointed out somewhere, the references to qhub in upgrade/test_upgrade will need to remain as is (at least for the time being). @viniciusdc opened issue #1512 to track this.

viniciusdc · 2022-10-26T11:55:13Z

nebari/template/stages/02-infrastructure/azure/modules/kubernetes/main.tf

  # DNS prefix specified when creating the managed cluster. Changing this forces a new resource to be created.
-  dns_prefix = "Qhub" # required
+  dns_prefix = "Nebari" # required

  # Azure requires that a new, non-existent Resource Group is used, as otherwise the provisioning of the Kubernetes Service will fail.


Just flagging this as important information for the migration notes

viniciusdc · 2022-10-26T11:56:55Z

nebari/template/stages/05-kubernetes-keycloak/main.tf

@@ -1,4 +1,4 @@
-resource "random_password" "keycloak-qhub-bot-password" {
+resource "random_password" "keycloak-nebari-bot-password" {


uhm... this will change Keycloak admin-level password, not user interactable but its good to flag

viniciusdc · 2022-10-26T11:58:28Z

...s/07-kubernetes-services/modules/kubernetes/services/jupyterhub/files/jupyterhub/01-theme.py

@@ -1,4 +1,4 @@
-from qhub_jupyterhub_theme import theme_extra_handlers, theme_template_paths
+from nebari_jupyterhub_theme import theme_extra_handlers, theme_template_paths


was this released?

viniciusdc

LGTM, we need to discuss about upgrade and the theming changes

* Switch to CalVer (#1501) * Run CI on branchs release/** * Update pyproject.toml to use calver * Update on branch * Update theme welcome messages to use Nebari (#1503) * update welcome messge * remove qhub specifics from theme * Name change QHub --> Nebari (#1508) * Name change: .github * Name change: qhub/ * Name change: tests/ * Name change: tests_deployment/ * Name change: tests_e2e/ * Name change: / * Rename folder * Rename releases * Remove qhub/ * Run pre-commit * Revert docs links * Fix infracost artifact names * Update upgrade command + test * Updates based on review * Update step output format * Fix: Update step output format * Update nebari/provider/cicd/common.py Co-authored-by: Tania Allard <[email protected]> * Update stage 08 folder names * Update nebari/schema.py Co-authored-by: Tania Allard <[email protected]> * Update nebari/template/stages/02-infrastructure/azure/variables.tf Co-authored-by: Tania Allard <[email protected]> * Update nebari/template/stages/02-infrastructure/do/variables.tf Co-authored-by: Tania Allard <[email protected]> * Update nebari/template/stages/02-infrastructure/gcp/variables.tf Co-authored-by: Tania Allard <[email protected]> * Update nebari/template/stages/02-infrastructure/gcp/variables.tf Co-authored-by: Tania Allard <[email protected]> * Update nebari/template/stages/03-kubernetes-initialize/variables.tf Co-authored-by: Tania Allard <[email protected]> * Update nebari/template/stages/05-kubernetes-keycloak/variables.tf Co-authored-by: Tania Allard <[email protected]> * Update nebari/template/stages/06-kubernetes-keycloak-configuration/variables.tf Co-authored-by: Tania Allard <[email protected]> * Update nebari/template/stages/06-kubernetes-keycloak-configuration/variables.tf Co-authored-by: Tania Allard <[email protected]> * Update nebari/template/stages/07-kubernetes-services/modules/kubernetes/forwardauth/variables.tf Co-authored-by: Tania Allard <[email protected]> * Update setup.cfg Co-authored-by: Tania Allard <[email protected]> * Update scripts/aws-force-destroy.py Co-authored-by: Tania Allard <[email protected]> * Update setup.cfg Co-authored-by: Tania Allard <[email protected]> * Update setup.cfg Co-authored-by: Tania Allard <[email protected]> * Update setup.cfg Co-authored-by: Tania Allard <[email protected]> * Update setup.cfg Co-authored-by: Tania Allard <[email protected]> * Update nebari/constants.py Co-authored-by: Vinicius D. Cerutti <[email protected]> * Update setup.cfg Co-authored-by: Tania Allard <[email protected]> * fix flake8 complaint * Update ref to qhub-dask to nebari-dask * Update readme * Change to PYPI_API_TOKEN Co-authored-by: viniciusdc <[email protected]> Co-authored-by: Tania Allard <[email protected]> Co-authored-by: Vinicius D. Cerutti <[email protected]> * qhub/initialize: lazy load attributes that require remote information (#1509) * qhub/initialize: lazy load attributes that require remote information * Fix broken configuration * fix renaming * fix header text * Update nebari/initialize.py * Update nebari/initialize.py * Blackify Co-authored-by: Amit Kumar <[email protected]> Co-authored-by: Nebari-sensei <[email protected]> * Update README logo (#1514) * Add fix, enhancements and pytests for CLI (#1498) * Add fix, enhancements and pytests for CLI * No zero-padded month for CalVer release branches * Update cli test * Simplify test.yaml * Remove old CLI + cleanup (#1519) * Remove old cli * Update theme * Remove shim * display_version: True * Update `skip_remote_state_provision` default value (#1521) * Add release notes for 2022.10.1 (#1523) * Add release notes for 2022.10.1 * Wording * Update README.md with new docs links * Update README.md with new docs links Co-authored-by: Vinicius D. Cerutti <[email protected]> * Remove leading `v` for release action (#1526) * Remove leading v for release tags * Add note to release checklist * Merge release branch into main Co-authored-by: Pavithra Eswaramoorthy <[email protected]> Co-authored-by: viniciusdc <[email protected]> Co-authored-by: Tania Allard <[email protected]> Co-authored-by: Vinicius D. Cerutti <[email protected]> Co-authored-by: Filipe Laíns <[email protected]> Co-authored-by: Amit Kumar <[email protected]> Co-authored-by: Nebari-sensei <[email protected]>

iameskild added 8 commits October 25, 2022 16:15

Name change: .github

aae3e19

Name change: qhub/

41c71f5

Name change: tests/

93bb786

Name change: tests_deployment/

6482058

Name change: tests_e2e/

29cdf3b

Name change: /

8dc5dec

Rename folder

ade8ba1

Rename releases

875c510

viniciusdc mentioned this pull request Oct 25, 2022

Rename qhub to Nebari (codebase) #1505

Closed

15 tasks

Remove qhub/

5ab53a7

iameskild and others added 4 commits October 25, 2022 17:24

Run pre-commit

b9d0165

Revert docs links

37faa11

Fix infracost artifact names

75ef358

Update upgrade command + test

d082bee