Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the default instance sizes #1338

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

peytondmurray
Copy link
Contributor

@peytondmurray peytondmurray commented Jun 21, 2022

Closes #1111 and #37

Changes introduced in this PR:

  • Doubled the profile sizes for the small and medium workers.
  • Doubled the node sizes across the board for all cloud providers
  • Increased the default conda-store storage to 200G, and the shared filesystem to 200G as well
  • Updated documentation to reflect these changes

Types of changes

What types of changes does your PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): Increases the default node sizes and worker profile sizes across the board.

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

After talking to several people on the nebari team and checking some existing deployment profiles, I've doubled the node and profile sizes across the board. If others feel that we should increase these defaults further, I'm happy to make that change.

@peytondmurray peytondmurray changed the title [WIP] Increase the default instance sizes Increase the default instance sizes Jun 22, 2022
@peytondmurray peytondmurray marked this pull request as ready for review June 22, 2022 00:27
@peytondmurray peytondmurray force-pushed the increase-default-instance-sizes branch from 2a41a4f to 3de5c11 Compare June 22, 2022 18:09
@peytondmurray peytondmurray force-pushed the increase-default-instance-sizes branch from 3de5c11 to fc3ce25 Compare June 22, 2022 18:13
@peytondmurray peytondmurray added the needs: review 👀 This PR is complete and ready for reviewing label Jun 22, 2022
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Infracost cost breakdown would be nice in this situation, but I realize we're not touching any tf files so I'm not sure how we would handle that.

Anyway, thanks for this @peytondmurray 🎉

@iameskild iameskild added this to the Release v0.4.3 milestone Jun 23, 2022
@peytondmurray peytondmurray merged commit 2b965f9 into main Jun 23, 2022
@peytondmurray peytondmurray deleted the increase-default-instance-sizes branch June 23, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review 👀 This PR is complete and ready for reviewing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Increase general node default size
2 participants