Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minio, postgresql chart repo location #1308

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Update minio, postgresql chart repo location #1308

merged 3 commits into from
Jun 7, 2022

Conversation

iameskild
Copy link
Member

Fixes | Closes | Resolves - Related to #1306

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@@ -11,7 +11,7 @@ resource "helm_release" "minio" {
repository = "https://charts.bitnami.com/bitnami"
chart = "minio"
# last release that was Apache-2.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comments makes me think a discussion around licenses might need to happen before we merge this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if 9.2.10 is one of the recent releases we might not be able to use that one because they switched their license to AGLPv3, which raises some licensing problems as discussed in #987. I agree that we need to talk about this as well, we might even need to use another service.

@trallard trallard added type: bug 🐛 Something isn't working needs: review 👀 This PR is complete and ready for reviewing labels Jun 6, 2022
@iameskild iameskild added this to the Release v0.4.2 milestone Jun 7, 2022
@magsol
Copy link
Contributor

magsol commented Jun 7, 2022

Discussion link #987

@iameskild iameskild requested a review from viniciusdc June 7, 2022 16:44
@iameskild iameskild changed the title Update minio, postgresql charts Update minio, postgresql chart repo location Jun 7, 2022
@viniciusdc
Copy link
Contributor

Just tested with a fresh deployment on GCP + the passing test with Minikube

│   labels:                                                                                                                                                              │
│     app.kubernetes.io/instance: qhub-conda-store-minio                                                                                                                 │
│     app.kubernetes.io/managed-by: Helm                                                                                                                                 │
│     app.kubernetes.io/name: minio                                                                                                                                      │
│     helm.sh/chart: minio-6.7.4                                                                                                                                         │
│     pod-template-hash: 648b7bc6ff  

@viniciusdc
Copy link
Contributor

I also confirmed the license in the service just to be sure:

@qhub-conda-store-minio-648b7bc6ff-lwrdp:/opt/bitnami/minio-client/licenses$ cat minio-client-2021.4.22.txt 
APACHE2: http://www.apache.org/licenses/LICENSE-2.0.txt

all seems ok to me. Thanks @iameskild

Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@viniciusdc viniciusdc merged commit 9a4969e into main Jun 7, 2022
@iameskild iameskild deleted the 20220605eae branch June 7, 2022 20:54
iameskild added a commit that referenced this pull request Jun 8, 2022
* Update minio, postgresql charts

* Update bitnami index url

* Update url

Co-authored-by: Eskild Eriksen <[email protected]>
iameskild added a commit that referenced this pull request Jun 9, 2022
* Update minio, postgresql chart repo location (#1308)

* Update minio, postgresql charts

* Update bitnami index url

* Update url

Co-authored-by: Eskild Eriksen <[email protected]>

* Add release notes, postmoderm

* Fix broken AWS, set minimum desired size to 1, enable 0 scaling (#1304)

* Update release notes

* clean up

* Update RELEASE.md

Co-authored-by: Vinicius D. Cerutti <[email protected]>

* Update RELEASE.md

Co-authored-by: Vinicius D. Cerutti <[email protected]>

* Update RELEASE.md

Co-authored-by: Vinicius D. Cerutti <[email protected]>

* Update RELEASE.md

Co-authored-by: Vinicius D. Cerutti <[email protected]>

Co-authored-by: Eskild Eriksen <[email protected]>
Co-authored-by: iameskild <[email protected]>
Co-authored-by: Tyler <[email protected]>
Co-authored-by: Vinicius D. Cerutti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review 👀 This PR is complete and ready for reviewing type: bug 🐛 Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

4 participants