-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minio, postgresql chart repo location #1308
Conversation
@@ -11,7 +11,7 @@ resource "helm_release" "minio" { | |||
repository = "https://charts.bitnami.com/bitnami" | |||
chart = "minio" | |||
# last release that was Apache-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comments makes me think a discussion around licenses might need to happen before we merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if 9.2.10
is one of the recent releases we might not be able to use that one because they switched their license to AGLPv3, which raises some licensing problems as discussed in #987. I agree that we need to talk about this as well, we might even need to use another service.
Discussion link #987 |
Just tested with a fresh deployment on GCP + the passing test with Minikube
|
I also confirmed the license in the service just to be sure:
all seems ok to me. Thanks @iameskild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Update minio, postgresql charts * Update bitnami index url * Update url Co-authored-by: Eskild Eriksen <[email protected]>
* Update minio, postgresql chart repo location (#1308) * Update minio, postgresql charts * Update bitnami index url * Update url Co-authored-by: Eskild Eriksen <[email protected]> * Add release notes, postmoderm * Fix broken AWS, set minimum desired size to 1, enable 0 scaling (#1304) * Update release notes * clean up * Update RELEASE.md Co-authored-by: Vinicius D. Cerutti <[email protected]> * Update RELEASE.md Co-authored-by: Vinicius D. Cerutti <[email protected]> * Update RELEASE.md Co-authored-by: Vinicius D. Cerutti <[email protected]> * Update RELEASE.md Co-authored-by: Vinicius D. Cerutti <[email protected]> Co-authored-by: Eskild Eriksen <[email protected]> Co-authored-by: iameskild <[email protected]> Co-authored-by: Tyler <[email protected]> Co-authored-by: Vinicius D. Cerutti <[email protected]>
Fixes | Closes | Resolves - Related to #1306
Changes introduced in this PR:
Types of changes
What types of changes does your PR introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Documentation
Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.