Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the commit of the terraform rendering optional (replaces PR 995) #1149

Merged
merged 12 commits into from
Mar 8, 2022

Conversation

iameskild
Copy link
Member

Fixes | Closes | Resolves
Replaces PR #995

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

  • Make the commit of the terraform rendering optional in the qhub_ops.yaml / .gitlab_ci.yaml

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

qhub/provider/cicd/gitlab.py Outdated Show resolved Hide resolved
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @iameskild 🎉

qhub/initialize.py Outdated Show resolved Hide resolved
qhub/schema.py Outdated Show resolved Hide resolved
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all the requests!

qhub/schema.py Outdated Show resolved Hide resolved
qhub/initialize.py Outdated Show resolved Hide resolved
@iameskild
Copy link
Member Author

No worries @costrouc! I appreciate your (and @viniciusdc's) feedback. If I had been more thoughtful to begin with, I think I could have avoided many of this corrections 😅

@costrouc costrouc merged commit 3275843 into main Mar 8, 2022
@costrouc costrouc deleted the replace_pr_995 branch March 8, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants