Fix input variable support for multiple types #1029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1028
The current
map
type forauthentication
lead to terraform to decide the type of variables it will be receiving from the input. But, when using extra forms of authentication likeGithub, Auth0
the extra fieldauthentication.config
has a dict type structure, andauthentication.type
has an str type structure which lead to the following error when deploying the stage:edit.: Opted for variable type:
any
as usingobject
structure obliges the variable input to have the same structure as specified which conflicts with the authentication modes of qhub (some does not include theconfig
key)Changes:
authentication
type to include multiple value types.Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Further comments (optional)
Already tested on minikube local deployment with Auth0 config.