Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JupyterHub to 2.0 or greater #1763

Closed
iameskild opened this issue May 1, 2023 · 9 comments
Closed

Upgrade JupyterHub to 2.0 or greater #1763

iameskild opened this issue May 1, 2023 · 9 comments
Labels
area: dependencies 📦 All things dependencies impact: high 🟥 This issue affects most of the nebari users or is a critical issue needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug

Comments

@iameskild
Copy link
Member

This issue will act as a central place for us to discuss and document what it would take to upgrade JupyterHub to version 2.0 or greater; JupyterHub 4.0 was just released earlier this year . We are currently running on quite an old version (1.5) and sooner or later this will likely cause us issues.

Z2JH has documented what is required to upgrade from 1.* to 2.*.

@iameskild iameskild added area: dependencies 📦 All things dependencies impact: high 🟥 This issue affects most of the nebari users or is a critical issue needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug labels May 1, 2023
@iameskild iameskild mentioned this issue May 1, 2023
10 tasks
@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented Jun 29, 2023

https://jupyterhub.readthedocs.io/en/latest/reference/changelog.html#id75 could be useful as well

One problem I already see is all our jupyterhub services are admins at the moment and we'll need to change that.

It should also be noted that Z2JH has documented what is required to upgrade from 1.* to 2.*.

Note that Z2JH v2 uses Jupyterhub 3. They migrated directly from jupyterhub 1.x to 3.x.

@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented Jun 29, 2023

Looks like we'll have to drop support for CDSDashboards if we want to do this soon. ideonate/cdsdashboards#96

@Adam-D-Lewis
Copy link
Member

Managed to build an image with jupyterhub 3 that didn't throw any errors on startup of the hub pod on nebari at least
nebari-dev/nebari-docker-images@78ecfe0

@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented Jun 30, 2023

The Z2JH jupyterhub docker image changed from a base Ubuntu image to a base debian-bullseye image. This may force us to change our image, but not sure yet - https://github.com/jupyterhub/zero-to-jupyterhub-k8s/blob/2.0.0/images/hub/Dockerfile.

@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented Jun 30, 2023

Seeing this error, looks like I'll need to upgrade jupyterlab image as well - jupyterhub version 3.1.1 != jupyterhub-singleuser version 1.5.0. This could cause failure to authenticate and result in redirect loops! Update: Fixed by upgrading jupyterhub version on jupyterlab pod.

@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented Jun 30, 2023

I thought that these services will need to be adjusted in order to work in the latest jupyterhub, but they still seem to work for the moment despite admin being deprecated.

services = concat([
"dask-gateway"
],
(var.monitoring-enabled ? ["monitoring"] : []),
(var.prefect-enabled ? ["prefect"] : []),
(var.kbatch-enabled ? ["kbatch"] : [])
)

@Adam-D-Lewis
Copy link
Member

Okay, I seem to have a working version of Nebari with Jupyterhub 3. I tested the dashboards in grafana, running a small dask cluster on a small computation, creating a conda environment in conda store, creating users manually in keycloak. Only thing that doesn't work is CDSDashboards and idk a way around that til we get a replacement built.

@Adam-D-Lewis
Copy link
Member

Related Issue that should probably be included in this PR: #1854

@iameskild
Copy link
Member Author

Closed by #1856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 All things dependencies impact: high 🟥 This issue affects most of the nebari users or is a critical issue needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug
Projects
Development

No branches or pull requests

2 participants