This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Expose batch authorization in Hapi 17 plugin #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
commented
Sep 3, 2018
| @@ -294,11 +338,10 @@ lab.experiment('Authorization inherited org policies', () => { | |||
| } | |||
| }) | |||
|
|
|||
| server.inject(options, (response) => { | |||
There was a problem hiding this comment.
this and the below tests were mistakenly succeeding, I was actually puzzled as to why because the API didn't exist in the hapi 17 plugin, and eventually realized that they were not asserting correctly, probably because of a copy/paste from the hapi 16 plugin package, which uses callback-based assertions VS the async-based assertions used here instead.
- add tests - fix existing tests which were succeding because wrongly implemented
simoneb
force-pushed
the
issue-555-batch-authorization
branch
from
715e970
to
1350ee8
Compare
|
will merge and check/repair tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #555
Also includes: