chore: promote staging to main (2026-03-11 21:09 UTC) - #962
Merged
henrypark133 merged 2 commits intoMar 11, 2026
Merged
henrypark133 merged 2 commits into
henrypark133 merged 2 commits into
Conversation
The telegram-tests, windows-build, wasm-wit-compat, and docker-build jobs were skipped during staging CI because their `if` conditions only matched `push` and `pull_request` events. When staging-ci.yml calls test.yml via workflow_call, github.event_name is `schedule` (inherited from the caller), which matched neither condition. Invert the conditions to blocklist the one case we want to skip (PRs targeting staging) instead of allowlisting specific events. This handles schedule, workflow_dispatch, and any future trigger types. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
The Claude review step was failing ~40% of the time because: - --allowedTools didn't include Read, Glob, Grep, Agent, causing 8-9 permission denials per run and preventing Claude from reading files or spawning the subagents the prompt required - Step 4 spawned N additional scoring agents per issue found, exhausting the 50-turn budget before the PR comment could be posted - Subagents could independently post PR comments, causing fragmented output Fix: add missing tools to --allowedTools, merge per-issue scoring into the review agents themselves, and add guardrails ensuring exactly one consolidated comment is always posted. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Code reviewFound 1 issue:
Original condition:
New condition:
When the workflow is triggered via This affects 4 jobs: telegram-tests, windows-build, wasm-wit-compat, docker-build. Suggested fix: Keep the original condition, or refactor to explicitly handle all trigger types: |
henrypark133
approved these changes
Mar 11, 2026
henrypark133
merged commit Mar 11, 2026
ffbc0cd
into
staging-promote/34550add-22970193833
26 of 27 checks passed
bkutasi
pushed a commit
to bkutasi/ironclaw
that referenced
this pull request
Mar 28, 2026
…974575035 chore: promote staging to main (2026-03-11 21:09 UTC)
drchirag1991
pushed a commit
to drchirag1991/ironclaw
that referenced
this pull request
Apr 8, 2026
…974575035 chore: promote staging to main (2026-03-11 21:09 UTC)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-promotion from staging CI
Batch range:
34550add3ee85bab6fe1c670dff46871d1a41e04..d313f44a1977a52af023abfdfc52a378fed2c8f0Promotion branch:
staging-promote/d313f44a-22974575035Base:
staging-promote/34550add-22970193833Triggered by: Staging CI batch at 2026-03-11 21:09 UTC
Waiting for gates:
Auto-created by staging-ci workflow