Skip to content

chore: promote staging to main (2026-03-11 21:09 UTC) - #962

Merged
henrypark133 merged 2 commits into
staging-promote/34550add-22970193833from
staging-promote/d313f44a-22974575035
Mar 11, 2026
Merged

henrypark133 merged 2 commits into
staging-promote/34550add-22970193833from
staging-promote/d313f44a-22974575035

Conversation

@ironclaw-ci

@ironclaw-ci ironclaw-ci Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Auto-promotion from staging CI

Batch range: 34550add3ee85bab6fe1c670dff46871d1a41e04..d313f44a1977a52af023abfdfc52a378fed2c8f0
Promotion branch: staging-promote/d313f44a-22974575035
Base: staging-promote/34550add-22970193833
Triggered by: Staging CI batch at 2026-03-11 21:09 UTC

Waiting for gates:

  • Tests: pending
  • E2E: pending
  • Claude Code review: pending (will post comments on this PR)

Auto-created by staging-ci workflow

henrypark133 and others added 2 commits March 11, 2026 14:04
The telegram-tests, windows-build, wasm-wit-compat, and docker-build
jobs were skipped during staging CI because their `if` conditions only
matched `push` and `pull_request` events. When staging-ci.yml calls
test.yml via workflow_call, github.event_name is `schedule` (inherited
from the caller), which matched neither condition.

Invert the conditions to blocklist the one case we want to skip (PRs
targeting staging) instead of allowlisting specific events. This handles
schedule, workflow_dispatch, and any future trigger types.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
The Claude review step was failing ~40% of the time because:
- --allowedTools didn't include Read, Glob, Grep, Agent, causing 8-9
  permission denials per run and preventing Claude from reading files
  or spawning the subagents the prompt required
- Step 4 spawned N additional scoring agents per issue found, exhausting
  the 50-turn budget before the PR comment could be posted
- Subagents could independently post PR comments, causing fragmented output

Fix: add missing tools to --allowedTools, merge per-issue scoring into
the review agents themselves, and add guardrails ensuring exactly one
consolidated comment is always posted.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot added scope: ci CI/CD workflows size: M 50-199 changed lines risk: medium Business logic, config, or moderate-risk modules contributor: experienced 6-19 merged PRs labels Mar 11, 2026
@claude

claude Bot commented Mar 11, 2026

Copy link
Copy Markdown

Code review

Found 1 issue:

  1. [HIGH:100] Logical equivalence bug in workflow conditions changes in test.yml — the refactored conditions are NOT logically equivalent for all event types. The workflow can be triggered via workflow_call in addition to push and pull_request.

Original condition: github.event_name == 'push' || (github.event_name == 'pull_request' && github.base_ref \!= 'staging')

  • Runs on: pushes to main, PRs to non-staging branches
  • Skips on: PRs to staging branch

New condition: github.event_name \!= 'pull_request' || github.base_ref \!= 'staging')

  • Runs on: all non-PR events (including workflow_call), PRs to non-staging branches
  • Skips on: PRs to staging branch only

When the workflow is triggered via workflow_call (defined in line 3 of test.yml), the new condition evaluates to TRUE, causing these expensive tests to run unintentionally. The original condition correctly skips them.

This affects 4 jobs: telegram-tests, windows-build, wasm-wit-compat, docker-build.

Suggested fix: Keep the original condition, or refactor to explicitly handle all trigger types: (github.event_name == 'push') || (github.event_name == 'pull_request' && github.base_ref \!= 'staging')

https://github.com/anthropics/ironclaw/blob/f08220db8201013acffff05898b261d81f7f0f5e/.github/workflows/test.yml#L42-L46

@henrypark133
henrypark133 merged commit ffbc0cd into staging-promote/34550add-22970193833 Mar 11, 2026
26 of 27 checks passed
@henrypark133
henrypark133 deleted the staging-promote/d313f44a-22974575035 branch March 11, 2026 21:25
bkutasi pushed a commit to bkutasi/ironclaw that referenced this pull request Mar 28, 2026
…974575035

chore: promote staging to main (2026-03-11 21:09 UTC)
drchirag1991 pushed a commit to drchirag1991/ironclaw that referenced this pull request Apr 8, 2026
…974575035

chore: promote staging to main (2026-03-11 21:09 UTC)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: experienced 6-19 merged PRs risk: medium Business logic, config, or moderate-risk modules scope: ci CI/CD workflows size: M 50-199 changed lines staging-promotion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant