Repository navigation
Conversation
…d reality Every main push since 2026-08-13 12:12 has failed Tests (Reborn) on the integration-tier coverage ratchet (first red: run 31698975156; latest: 31796056891). The 08-13 merges legitimately shrank both floored crates — the slack standard-ops rework and the telegram sticker/voice ingress pruning deleted code and tests together — and the coverage-report job is planned only on main pushes, so neither the PR lanes nor the merge queue ever saw the breach and the queue kept merging over a red main. Per the gate's own remedy for legitimate shrinkage, re-pin both entries to the observed numbers from run 31796056891: slack: 93.95% / 3697 of 3935 -> 93.57% / 3666 of 3918 telegram: 90.31% / 1435 of 1589 -> 87.46% / 1200 of 1372 Tolerances unchanged; rationale/issue rows unchanged. Follow-up: the telegram entry must be re-measured when #7464 lands (it grows the crate substantially and its linked-account half is covered at crate tier, not integration tier). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LACC5dKyNy3GNXRNbvgz57
|
🚅 Deployed to the ironclaw-pr-7655 environment in ironclaw-ci-preview
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe integration coverage-floor metadata records updated Slack and Telegram measurements captured on 2026-08-14. The Telegram entry documents coverage dilution from linked-device functionality. ChangesCoverage floor refresh
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: 🔴 Critical · up to Although this PR only changes CI coverage-floor data, the current manifest is reported to contain an extra crate header that can make the coverage gate fail; merge should be blocked until the telegram entry structure is corrected. Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧭 IronLoop Run · ReviewThis comment updates in place as the Run moves through its stages. 🟩 Final result · Completed
Automatic trigger · attempt 1 of 3 · completed in 1m IronLoop completed the review and posted it to GitHub. 🔗 Result |
There was a problem hiding this comment.
🔍 IronLoop review
🟢 No actionable findings
No actionable issues found in the coverage-floor re-pin.
Validation
- ✅ Coverage floor manifest — The updated Slack and Telegram line counts parse successfully, and each percentage matches its captured covered/total-line values when rounded to two decimals.
- ✅ Pull request coverage gate — The captured integration-tier coverage report completed successfully with the updated manifest.
Review details
- Run:
6c30a1c9-bc18-45bd-9a7a-b595255b3d7f - Workflow: Review
- Attempts: 1
The follow-up this PR predicted arrived before it merged: #7464 grew the telegram crate by ~2.7k linked-device lines that are covered at the crate tier (the MTProto handshake cannot run in the integration harness), so the integration-tier percent moved from the pre-merge 87.46% (1200/1372) to 56.63% (2410/4256) — measured by main's own gate on the #7658 merge push (run 31819915736). Slack's entry already matches the current observed values. A comment above the entry records the tier split so the number reads as deliberate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LACC5dKyNy3GNXRNbvgz57
What
Re-pins the integration-tier coverage ratchet floors for the two failing crates to the observed numbers from main's own gate output (run 31796056891):
slacktelegramTolerances, rationale, and issue links are unchanged; only the four captured numbers move per entry.
Why
Every main push since 2026-08-13 12:12 has failed
Tests (Reborn)on theReborn integration-tier coverage reportjob (first red: run 31698975156; last green main push: 2026-08-12 18:32). The 08-13 merges legitimately shrank both floored crates — code and tests deleted together (slack standard-ops rework era, telegram sticker/voice ingress pruning) — which is exactly the "legitimate shrinkage" case the gate's failure text says to resolve by re-pinning the[[crate]]entry to observed numbers.Nobody noticed for ~24h because the coverage-report job is planned only on main pushes: the PR lanes and the merge queue both skip it, so the queue kept merging over a red main.
Compatibility / rollback
Data-free CI-config change; revert the commit to restore the old floors. No runtime behavior.
Follow-ups
The— happened before merge; the entry is now pinned to main's own post-feat(telegram): pair linked devices with the bot channel #7464 gate output (run 31819915736): 56.63% · 2410 of 4256. The percent drop is denominator growth from the linked-device half, which is deliberately crate-tier covered (the MTProto handshake cannot run in the integration harness); a comment above the entry records the tier split.telegramentry must be re-measured when feat(telegram): pair linked devices with the bot channel #7464 landsmerge_groupso floor breaches eject in the queue instead of landing on main.Regression-test exemption: deterministic reproduction is impossible because this PR changes only the coverage gate's own data manifest (four floor numbers in tests/integration/coverage-floor.toml); the consuming gate runs solely on main pushes, so the next main push after merge is the only executable verification, and no unit of production behavior exists to reproduce or pin.
Test Strategy
tomllib; entry schema matches the file's documented[[crate]]shape (all four captured fields updated together).🤖 Generated with Claude Code
https://claude.ai/code/session_01LACC5dKyNy3GNXRNbvgz57