Skip to content

chore: remove IronLoop small-fix role instructions - #7415

Merged
hanakannzashi merged 2 commits into
mainfrom
chore/remove-dogfood-role-instructions
Aug 10, 2026
Merged

hanakannzashi merged 2 commits into
mainfrom
chore/remove-dogfood-role-instructions

Conversation

@hanakannzashi

@hanakannzashi hanakannzashi commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove IronClaw's repository-specific Implement, Review, and Resolve instruction files and their configuration entries.
  • Start by exercising IronLoop's built-in workflow guidance on IronClaw itself instead of constraining it to small, clear, low-risk fixes.
  • Add repository-specific role instructions back only when observed behavior shows a concrete need.

Change Type

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • CI/Infrastructure
  • Security
  • Dependencies

Linked Issue

None.

Validation

  • cargo fmt --all -- --check
  • cargo clippy --all --benches --tests --examples --all-features -- -D warnings
  • cargo build
  • Relevant tests pass: not applicable; no Rust behavior changed.
  • cargo test -p <owning-crate> --features integration if database-backed or runtime-integration behavior changed (the root integration feature is empty — the flag is per-crate)
  • Manual testing: parsed .ironloop/config.yaml, verified no role has an instructions entry, and ran git diff --check.
  • If a coding agent was used and supports it, review-pr or pr-shepherd --fix was run before requesting review

Test Strategy

User behavior: New IronLoop Runs use the built-in Implement, Review, and Resolve guidance together with IronClaw's normal repository instructions. Existing role-specific constraints no longer limit work to small fixes.

Risk areas:

  • Model behavior
  • Browser
  • Side effect
  • Persistence
  • Security or permissions
  • External provider
  • Cross-component behavior

Tests added or updated:

  • Unit or contract: Not applicable: configuration-only change.
  • Reborn integration: Not applicable.
  • Recorded fixture: Not applicable.
  • Browser E2E: Not applicable.
  • Backend or runtime: Not applicable.
  • Live canary: Observe subsequent IronLoop Runs before deciding whether a repository-specific instruction is warranted.

What the tests prove: The configuration remains valid and has no stale role-instruction references.

Commands run:

  • git diff --check
  • Ruby YAML parse and semantic assertion for the role entries

Security Impact

None. This removes repository-specific prompt guidance; it does not change credentials, sandbox policy, network access, or permissions.

Reborn Trust-Boundary Checklist

N/A: no Reborn, runtime, database, or trust-boundary code changes.

Database Impact

None.

Blast Radius

Future IronLoop Runs in this repository no longer receive the deleted small-fix-only role instructions.

Rollback Plan

Restore the three instruction files and their instructions paths in .ironloop/config.yaml if actual IronLoop behavior demonstrates a repository-specific need.

Review Follow-Through

Reviewer judgment is requested on whether removing the dogfood restrictions is the right default. Follow-up instructions should be added only in response to a concrete observed gap.


Review track: B (maintainer-requested refactor)

@railway-app

railway-app Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

🚅 Deployed to the ironclaw-pr-7415 environment in ironclaw-ci-preview

Service Status Web Updated (UTC)
ironclaw ✅ Success (View Logs) Web Aug 10, 2026 at 5:48 am

@railway-app
railway-app Bot temporarily deployed to ironclaw-ci-preview / ironclaw-pr-7415 August 10, 2026 05:35 Destroyed
@github-actions github-actions Bot added scope: docs Documentation size: XS < 10 changed lines (excluding docs) risk: low Changes to docs, tests, or low-risk modules contributor: core 20+ merged PRs labels Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 55b9dad4-d369-43c9-b782-8734ad37d15e

📥 Commits

Reviewing files that changed from the base of the PR and between 9060afc and ec0d37c.

📒 Files selected for processing (2)
  • scripts/ci/reborn_pr_test_plan.py
  • scripts/ci/test_reborn_pr_test_plan.py

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Simplified project configuration by removing obsolete workflow references.
    • Removed outdated implementation, review, and resolution guidance to keep project setup cleaner.
    • Existing network access and automated workflow settings remain unchanged.
    • Excluded workflow configuration changes from automated test-plan routing while preserving testing for related source changes.

Walkthrough

The change removes Ironloop role instruction references and deletes the related guidance files. It also excludes .ironloop/ changes from Reborn Rust test-plan routing and adds regression coverage.

Changes

Ironloop changes

Layer / File(s) Summary
Remove role instruction references
.ironloop/config.yaml, .ironloop/implementer.md, .ironloop/reviewer.md, .ironloop/resolver.md
The configuration no longer references the role instruction files. The three guidance files were deleted. Network access and retained auto-operation settings remain configured.
Ignore Ironloop paths in test planning
scripts/ci/reborn_pr_test_plan.py, scripts/ci/test_reborn_pr_test_plan.py
The Reborn planner ignores .ironloop/ paths. Regression coverage verifies no Rust lane for Ironloop-only changes and preserves crate selection when a crate change is also present.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: benkurrek

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title uses Conventional Commits style and clearly identifies removal of the IronLoop role instructions.
Description check ✅ Passed The description covers the change, validation, impact, rollback, and review track, but it does not document the added CI regression tests.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ironloopai

ironloopai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

🧭 IronLoop Run · Review

This comment updates in place as the Run moves through its stages.

🟩 Final result · Completed

🟨 Queued → 🟦 Working → 🟦 Posting results → 🟩 Completed

Automatic trigger · attempt 1 of 3 · completed in 6m 20s

IronLoop completed the review and posted it to GitHub.

🔗 Result

Open submitted review →

Run details

Run: 79ad9d33-e640-4f18-aa27-5c015dd43763
Base: main at 89285c8
Head: chore/remove-dogfood-role-instructions at 9060afc
Created: 2026-08-10 05:36 UTC
Updated: 2026-08-10 05:43 UTC

@ironloopai ironloopai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 IronLoop review

One blocking CI-planning defect found.

Findings: 🟠 Medium 1

🟠 Medium · Classify IronLoop configuration changes for CI

Inline on .ironloop/config.yaml:4. See the inline comment for details.

Validation

  • ✅ Configuration YAML check — Parsed the updated configuration and verified retained role, network, auto-review, and auto-resolve settings.
  • ✅ Repository reference scan — No tracked files still reference the deleted role-guidance paths.
  • ❌ Reborn changed-path planning — The focused planner rejects `.ironloop/config.yaml` as an unclassified pull-request path.
  • ✅ Change whitespace check — No whitespace errors found in the change.
  • ⚪ IronLoop runtime validation — Not run. No local IronLoop runtime or schema validator was available; static inspection and focused YAML parsing were used.
Review details
  • Run: 79ad9d33-e640-4f18-aa27-5c015dd43763
  • Workflow: Review
  • Attempts: 1

Comment thread .ironloop/config.yaml
@railway-app
railway-app Bot temporarily deployed to ironclaw-ci-preview / ironclaw-pr-7415 August 10, 2026 05:47 Destroyed
@github-actions github-actions Bot added size: S 10-49 changed lines and removed size: XS < 10 changed lines (excluding docs) labels Aug 10, 2026
@hanakannzashi
hanakannzashi added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit 2042380 Aug 10, 2026
40 checks passed
@hanakannzashi
hanakannzashi deleted the chore/remove-dogfood-role-instructions branch August 10, 2026 09:05
Kampouse pushed a commit to Kampouse/ironclaw that referenced this pull request Aug 13, 2026
* chore: remove IronLoop small-fix role instructions

* ci: classify IronLoop configuration changes
Kampouse pushed a commit to Kampouse/ironclaw that referenced this pull request Aug 13, 2026
* chore: remove IronLoop small-fix role instructions

* ci: classify IronLoop configuration changes
l3ocifer pushed a commit to l3ocifer/frick-ironclaw that referenced this pull request Sep 3, 2026
* chore: remove IronLoop small-fix role instructions

* ci: classify IronLoop configuration changes

This branch was successfully deployed

No deployments
ironclaw-ci-preview / ironclaw-pr-7415 — ec0d37ca Deployed Aug 10, 2026 by railway-app[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: low Changes to docs, tests, or low-risk modules scope: docs Documentation size: S 10-49 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants