-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Waves 0–4 batch 2: register to zero, adapter-registry move, ruled decisions (accumulating the fleet) #7181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Waves 0–4 batch 2: register to zero, adapter-registry move, ruled decisions (accumulating the fleet) #7181
Changes from all commits
Commits
Show all changes
133 commits
Select commit
Hold shift + click to select a range
93007af
refactor(contracts): move extension runtime descriptors to a neutral …
BenKurrek 737cf50
refactor(sandbox): merge the sandbox lane into one crate (WS3)
BenKurrek adbbb58
docs(target-architecture): record the WS3 corrections with their evid…
BenKurrek 38be2e2
chore(sandbox): drop imports the merge left unused
BenKurrek 925e7e6
fix(ci): let the Reborn PR planner plan guidance edits and crate dele…
BenKurrek 5ed3ac5
fix(arch): give the retained resource exceptions an owning issue, not…
BenKurrek 50be425
test(contracts): pin the asset-path validator that moved into extensi…
BenKurrek 84af779
test(coverage): re-capture the host_runtime floor and floor the new s…
BenKurrek bce21dc
docs(target-architecture): record the coverage ratchet as a move-sens…
BenKurrek 5be9872
Merge origin/main into ws3/sandbox-and-mcp
BenKurrek 8d89b41
fix(extension-manager): repoint ironhub onto the moved ExtensionAsset…
BenKurrek 50712f0
test(coverage): exempt the WS3 move's no-region lines and record the …
BenKurrek a723345
docs(sandbox,mcp): correct the wiring inventory and record the projec…
BenKurrek 9a250ff
refactor(extensions): move the skill-install executor to extension_su…
BenKurrek 86b05a8
docs(sandbox): record that the Docker fail-closed switch is wired to …
BenKurrek f50504c
docs(host_runtime): record the executor/adapter seam in crate guidance
BenKurrek e07b3b0
refactor(host_runtime): keep the install-input error path log-free
BenKurrek 8be0715
ci(coverage): re-capture the host_runtime floor for the WS3 executor …
BenKurrek 482bea4
refactor(wasm): move wit/ inside its owning crate (Wave 3)
BenKurrek 21533fd
build(wasm): rebuild first-party artifacts for the moved wit/ path
BenKurrek 80daab9
docs(target-arch): record the WS7 artifact-rebuild cost of guest path…
BenKurrek 5a1b315
Merge remote-tracking branch 'origin/main' into wave3/wit-move
BenKurrek f9b4ae7
Merge origin/main into ws3/sandbox-and-mcp
BenKurrek 25e9aab
Merge origin/main into ws3/first-party-tools
BenKurrek 1f66b58
ci(planner): classify the path classes that blocked the wit/ move
BenKurrek 96d0d46
refactor(host-runtime): split obligations into its three chartered ow…
BenKurrek 452a2d6
refactor(operator,contracts): route operator secrets through a produc…
BenKurrek ec1ba88
test(sandbox): put the Docker security check behind the fail-closed gate
BenKurrek 6150a3f
docs(reborn): stop calling the unwired script lane an execution lane
BenKurrek 756205f
fix(ci): pin the WIT scope probes and the embedded-asset owner pairing
BenKurrek 043bc6c
docs(host-runtime): state the obligation visibility rule as it holds
BenKurrek c735e0c
fix(architecture): put the operator secrets boundary entry on the rig…
BenKurrek 93ab9e6
docs(sandbox): state the Docker-gate claim as the search that checks it
BenKurrek d249a1d
Merge remote-tracking branch 'origin/main' into ws3/sandbox-and-mcp
BenKurrek ae1162a
merge(ws3): sandbox lane + mcp contracts flip (#7065)
BenKurrek b4925fd
merge(wave3): move wit/ inside its owning crate (#7084)
BenKurrek e3a9724
merge(ws3): move the skill-install executor to extension_support (#7080)
BenKurrek 177eee8
merge(ws3): route operator secrets through a product_contracts port (…
BenKurrek 9ea9cf1
merge(ws3): split obligations into its three chartered owners (#7090)
BenKurrek 935ffe1
fix(coverage): re-anchor the exemptions the merge shifted
BenKurrek 75909be
Merge origin/main (#7094 Wave 2 close-out) and re-baseline the WS3 nu…
BenKurrek 8e299a7
refactor(layers): re-layer processes -> kernel and skills -> substrat…
BenKurrek 29aac22
docs(target-arch): close the WS3/WS4 rows this work satisfies, with e…
BenKurrek 4512e03
Merge origin/main into the consolidated WS3/WS4 branch
BenKurrek 939af48
ci(coverage): recapture the two composed floors from a real measurement
BenKurrek 2349548
fix(network): compile the test rewrite seam out of production builds …
BenKurrek 9fbffd1
docs(coverage): verify the extension_support floor drop is compositio…
BenKurrek 3c3189c
fix(host_runtime): collapse a duplicated obligation predicate and qui…
BenKurrek af14776
fix(ci): a shipped package prompt is an asset, not prose — it was sel…
BenKurrek ba79cb6
fix(harness): refresh the latency-runner lockfile after the sandbox c…
BenKurrek b57ac8e
fix(skills): stop rejecting inline bundle installs and stop dropping …
BenKurrek 05534b6
refactor(capabilities): split host.rs along its six workflows (WS3 Ro…
BenKurrek f2e69ad
docs(target-arch): retract the "W7 is Wave 5" premise and tighten the…
BenKurrek 8355cef
Merge branch 'ws3/row2-hostsplit' into ws3/consolidated
BenKurrek 85f55ee
test(architecture): fix drifted ratchet baselines and fail on slack (…
BenKurrek aaf6515
Merge remote-tracking branch 'origin/main' into ws3/consolidated
BenKurrek 05fc53f
docs(checklist): strike the egress-threat text the same row already r…
BenKurrek 31726cc
ci(composition): bound composition's absolute production LOC (#7151)
BenKurrek 61fece8
refactor(host_runtime): shed the catalog defaults downward (WS3 row 3)
BenKurrek def71bf
fix(operator): name the port call in LlmKeyStoreError::Store
BenKurrek 5079ca6
Merge branch 'ws3/row3-catalog' into ws3/consolidated
BenKurrek 324a1f6
test(architecture): inventory same-layer dependency edges (#7149)
BenKurrek 05ad65a
revert(skills): restore the hidden-field install guards — the review …
BenKurrek f417a40
test(architecture): census LLM-vendor names in the contracts family (…
BenKurrek a2f9623
Merge remote-tracking branch 'origin/main' into ws3/consolidated
BenKurrek ca4acb3
test(architecture): make the two new gates visible to CI's test-name …
BenKurrek 1a60f01
docs(target-architecture): record the four enforcement additions and …
BenKurrek 24f96ab
Merge origin/main into ws/enforcement-gates-7147
BenKurrek 966061f
fix(capabilities): make the auth-required enrichment total, dropping …
BenKurrek 7ba9c4e
refactor(capabilities): return the authorization policy helpers to au…
BenKurrek 68ac1dd
fix(docs,ci): correct the guest WIT path and delete a test that never…
BenKurrek 7f242ae
test(host-api): pin the process-sandbox capability literal as a valid id
BenKurrek 54ceefd
Merge origin/main into ws/enforcement-gates-7147
BenKurrek f4f1236
test(ci): pin the pre-commit staged-path selector after the WIT move
BenKurrek f39d086
Merge remote-tracking branch 'origin/main' into ws/enforcement-gates-…
BenKurrek 1e971dc
chore(ci): re-seed composition loc_ceiling at the merged-tree count (…
BenKurrek c16d0f2
Merge remote-tracking branch 'origin/main' into ws3-consolidated-merge
BenKurrek 9b4536c
chore(ci): move the absolute-mass record with its re-seeded ceiling (…
BenKurrek 54e6757
Merge remote-tracking branch 'origin/main' into ws3-consolidated-merge
BenKurrek ace2fa7
WS5: repoint conversations' turn vocabulary to host_api; record the s…
BenKurrek 20fcf8a
Merge ws3/consolidated (54e6757414) into ws5/conversations-turns-sever
BenKurrek 57971c2
WS5: record the trigger-poller bound mapping and the step-1 blocker
BenKurrek 790b739
WS3: lanes consume a narrow reserve/reconcile/release port (#7067)
BenKurrek 7a89c2b
Merge remote-tracking branch 'origin/ws3/consolidated' into ws3-gover…
BenKurrek caa9fc8
WS5: descend SubmitTurnResponse to host_api::turn; record the port-in…
BenKurrek 8b901f4
Merge remote-tracking branch 'origin/main' into ws3-consolidated-merge
BenKurrek 2153f0b
WS10: convert the loud path-keyed gates to inventory keying before th…
BenKurrek f858cfb
WS10: pin the hermetic suite's WebUI frontend resolution
BenKurrek ccf284c
fix(ci): restore the entry tail the exemptions-union resolution dropped
BenKurrek 23cabea
WS10: classify the repo-root scripts this PR touches in the test planner
BenKurrek d13fe3f
WS10: name the new gates so the Code Style lane actually runs them
BenKurrek 3038fdf
docs(ws10): record the two gate defects this PR's own CI surfaced
BenKurrek 2ce58fa
Merge remote-tracking branch 'origin/main' into ws3-consolidated-merge
BenKurrek cac037b
WS5: sever conversations -> turns by port inversion; register 4 -> 3
BenKurrek 6563d80
chore(ci): exempt the consolidation's internal-move re-attributions t…
BenKurrek 6769fd9
Merge remote-tracking branch 'origin/ws3/lane-governor-port' into ws/…
BenKurrek 35388b1
Merge remote-tracking branch 'origin/ws5/conversations-turns-sever' i…
BenKurrek 108344c
Merge remote-tracking branch 'origin/ws10/loud-path-inventory' into w…
BenKurrek 6e82bc2
Merge remote-tracking branch 'origin/ws/enforcement-gates-7147' into …
BenKurrek 89080c5
chore(arch): reconcile the same-layer inventory and downgrade pins wi…
BenKurrek f2093b3
fix(arch): repair the base-inherited clippy break in the specificity …
BenKurrek eb6838a
docs(arch): execute the three ruled WS4/WS6 decision rows
BenKurrek 58cedd4
refactor(mcp): split the single-file lane into seven chartered module…
BenKurrek 2578e5d
WS2: clear the extension_host->product vocabulary residue (ports 4->1…
BenKurrek 323f604
refactor(auth): charter the two engines and enforce their severance (…
BenKurrek 16be4d3
refactor(ws6): evict the profile approval gate from composition to ir…
BenKurrek 0f9f2d9
refactor(composition): evict the admin-user directory and blocked-aut…
BenKurrek f0f22db
refactor(composition): split turn-end trace capture into the traces p…
BenKurrek e9bd8dd
WS5: move adapter_registry parsing to its contracts/registry owners
BenKurrek ae564ef
docs(arch): re-ratchet composition mass to 42,938 and reconcile the W…
BenKurrek e2faa82
docs(webui): commit the handlers.rs module-charter map and enforce it…
BenKurrek 21222c6
refactor(layers): re-layer extension_support -> runtimes; the excepti…
BenKurrek c804c62
chore(batch): green-up — clippy doc-gap fix, enum-body classifier ext…
BenKurrek a651aa3
Merge remote-tracking branch 'origin/main' into ws/waves-0-4-batch
BenKurrek 2846e18
Merge remote-tracking branch 'origin/ws3/closeout' into ws/waves-0-4-…
BenKurrek 533fa82
Merge remote-tracking branch 'origin/ws5/adapter-registry-move' into …
BenKurrek 9e2aa18
Merge remote-tracking branch 'origin/ws6/decision-rows' into ws/waves…
BenKurrek c47cdc5
Merge remote-tracking branch 'origin/ws6/charters-remainder' into ws/…
BenKurrek de68f86
test(arch): re-key the struct-debt inventory entry that followed trac…
BenKurrek 34bf097
chore(batch): delete the never-wired no-egress test fixture that reds…
BenKurrek bd707a7
refactor(reborn): slim the composition re-export wall, type Extension…
BenKurrek 884bf16
Merge branch 'ws/waves-0-4-batch' into ws/waves-0-4-batch-2
BenKurrek 679b7e2
Merge remote-tracking branch 'origin/ws6/evictions-services' into ws/…
BenKurrek c5520c3
Merge remote-tracking branch 'origin/ws6/runtime-and-types' into ws/w…
BenKurrek 0b0eb31
WS2.5: gate + CHECKLIST reconciliation, and two pre-existing clippy reds
BenKurrek 4d7c62f
refactor(ws6): evict fire-time trigger-access policy from composition…
BenKurrek 10d1b2d
Merge remote-tracking branch 'origin/ws2/extension-host-residue' into…
BenKurrek b941678
docs(ws6): re-ratchet composition mass and record the eviction + seve…
BenKurrek 8197eef
fix(batch2): drop the stale product-rooted auth-prompt imports the re…
BenKurrek 9e6f1ad
fix(batch2): reachability-correct auth-prompt re-export; charter rows…
BenKurrek 3554c2f
Merge remote-tracking branch 'origin/ws6/evictions-policy' into ws/wa…
BenKurrek 7fef2cc
docs(arch): re-measure the product→loop_host sever on the batch union…
BenKurrek bf99439
Merge remote-tracking branch 'origin/main' into ws/waves-0-4-batch-2
BenKurrek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Parse multiline attributes before checking the annotation.
Line 250 stops the reverse scan on an interior line of a valid multiline
#[cfg(...)]attribute. The required// consumer: … · pinned by: …line above that attribute is then not found. The new gate rejects a valid re-export. Track attribute delimiters across lines before scanning the preceding comment block. Add a regression case with a multiline#[cfg(any(...))]attribute.As per path instructions, guardrails must handle multiline syntax.
🤖 Prompt for AI Agents
Source: Path instructions
✅ Confirmed as addressed by @BenKurrek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed — the line-above lookback only ever saw the single preceding line, so an annotation attached to a multi-line
pub useblock was invisible and the re-export passed the gate carrying no consumer note at all.Replaced with a bracket-aware reverse walk that steps back over the whole statement, extracted as
pub_use_consumer_annotationsand pinned with a 4-case fixture (single-line, multi-line braced, nested braces, annotation absent). Sabotage-checked: dropping the annotation from a multi-line block now fails the gate, where before it passed silently.Fix verified locally; lands via PR #7202 (folded from branch
ws/review-7181-round1) — commit254169717.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenKurrek, confirmed. The bracket-aware reverse walk and the multiline regression fixture address the guardrail gap. This satisfies the repository requirement that guardrails handle multiline syntax.🐇 ✅
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!
You are interacting with an AI system.