fix(web): prevent Enter key from sending message during IME composition - #715
Merged
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
github-actions
Bot
added
scope: channel/web
zmanian
approved these changes
Mar 8, 2026
zmanian
left a comment
zmanian
left a comment
Collaborator
There was a problem hiding this comment.
Clean fix. e.isComposing is the standard API for handling IME composition — well-supported across all modern browsers (Chrome 56+, Firefox 31+, Safari 10.1+). This prevents Enter from submitting mid-composition for CJK input users.
zmanian
enabled auto-merge (squash)
March 8, 2026 19:54
zmanian
approved these changes
Mar 8, 2026
zmanian
left a comment
zmanian
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - IME composition fix for web gateway.
This was referenced Mar 8, 2026
Closed
Merged
bkutasi
pushed a commit
to bkutasi/ironclaw
that referenced
this pull request
Mar 28, 2026
…on (nearai#715) Co-authored-by: Zaki Manian <zaki@iqlusion.io>
drchirag1991
pushed a commit
to drchirag1991/ironclaw
that referenced
this pull request
Apr 8, 2026
…on (nearai#715) Co-authored-by: Zaki Manian <zaki@iqlusion.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.