feat(setup): build ironclaw-worker Docker image in setup wizard

[ezhoureal]

Summary

After confirming Docker is available, the setup wizard now checks if the ironclaw-worker:latest image exists locally. If not found, it offers to build it from Dockerfile.worker or provides manual build instructions.

This fixes the job failures caused by missing Docker images when users enable the sandbox feature through the setup wizard.

Changes

• src/sandbox/container.rs: Added build_image() method to build Docker images from Dockerfiles
• src/setup/wizard.rs:
  • Added ensure_worker_image() method
  • Added Sandbox error variant to SetupError
  • Integrated image check/build into step_docker_sandbox()
  • Fixed pre-existing test for write_bootstrap_env

Testing

• Full quality gate passes: cargo fmt, cargo clippy (zero warnings)
• All tests pass (3 pre-existing failures unrelated to this change)

Fixes #459

🤖 Generated with Claude Code

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[zmanian]

The core idea is good -- users shouldn't have to manually figure out Docker image building. The secrets key auto-write is also a nice UX improvement.

Issues to address:

1. Blocking std::process::Command in async context (must fix). build_image() uses std::process::Command::output() -- a blocking call. Docker builds can take minutes and will starve the tokio runtime thread. Use tokio::process::Command instead, which is the pattern used elsewhere in the codebase.

2. Path traversal in build_image() public API (should fix). The method accepts arbitrary &Path for the Dockerfile with no validation. Since docker build executes arbitrary RUN commands from the Dockerfile, this is a code execution vector if any future caller passes user-controlled input. At minimum add a doc comment warning the path must be trusted.

3. Hardcoded image name (minor). ensure_worker_image() hardcodes "ironclaw-worker:latest" while the rest of the sandbox system uses SANDBOX_IMAGE from config. Should read from config.

4. Bundled concerns. Docker build + secrets key auto-write are unrelated features. The PR title only mentions Docker build. Consider splitting or updating the title/description.

[ezhoureal]

The core idea is good -- users shouldn't have to manually figure out Docker image building. The secrets key auto-write is also a nice UX improvement.

Issues to address:

1. Blocking std::process::Command in async context (must fix). build_image() uses std::process::Command::output() -- a blocking call. Docker builds can take minutes and will starve the tokio runtime thread. Use tokio::process::Command instead, which is the pattern used elsewhere in the codebase.

2. Path traversal in build_image() public API (should fix). The method accepts arbitrary &Path for the Dockerfile with no validation. Since docker build executes arbitrary RUN commands from the Dockerfile, this is a code execution vector if any future caller passes user-controlled input. At minimum add a doc comment warning the path must be trusted.

3. Hardcoded image name (minor). ensure_worker_image() hardcodes "ironclaw-worker:latest" while the rest of the sandbox system uses SANDBOX_IMAGE from config. Should read from config.

4. Bundled concerns. Docker build + secrets key auto-write are unrelated features. The PR title only mentions Docker build. Consider splitting or updating the title/description.

Thanks for the review. The secret key is from another PR #669 . I'll fix these issues.

[zmanian]

Review: feat(setup): build ironclaw-worker Docker image in setup wizard

Good feature that fills a real gap -- users enabling sandbox in the wizard would hit missing image errors. The graceful fallback to manual build instructions is well-designed. A few issues to address:

Issues

1. Wrong error variant for connect_docker() failure (bug)
In ensure_worker_image(), the connect_docker() error is mapped to SetupError::Auth:

let docker = connect_docker()
    .await
    .map_err(|e| SetupError::Auth(e.to_string()))?;

You already added SetupError::Sandbox(#[from] crate::sandbox::error::SandboxError) -- use it:

let docker = connect_docker().await?;

The From impl will handle the conversion automatically. Using Auth is semantically misleading and will confuse anyone debugging setup failures.

2. ContainerRunner::new(docker, image_name.clone(), 0) -- proxy_port=0
Passing 0 for proxy_port works because build_image() doesn't use it, but it's a code smell. Consider either:

• Adding a comment explaining why 0 is safe here, or
• Adding a ContainerRunner::for_build(docker, image) constructor that makes the intent clear

Not blocking, but worth addressing.

3. No tests (project policy)
The project's review discipline requires regression tests with fixes. At minimum, a unit test for build_image() error handling (e.g., mocking a failed docker build command) would be valuable. The ensure_worker_image() integration with the wizard is harder to test, but the build_image method itself is testable.

Minor

• The Sandbox variant in SetupError uses #[from] which is good, but double-check that it doesn't conflict with any other From impls that might also convert SandboxError.

What looks good

• Security doc comment on build_image() about trusted Dockerfile paths
• Build failure is non-fatal (prints manual instructions, returns Ok)
• Context directory logic is reasonable
• Two Dockerfile candidate paths is pragmatic

[ilblackdragon]

Thanks for contribution. Closing as #1757 merged.