-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Alert live-canary Slack channel on merge queue failures #7007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| repo_root="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)" | ||
| workflow="${repo_root}/.github/workflows/main-ci-slack-alerts.yml" | ||
| code_style_workflow="${repo_root}/.github/workflows/code_style.yml" | ||
|
|
||
| assert_contains() { | ||
| local expected="$1" | ||
| if ! grep -Fq -- "$expected" "$workflow"; then | ||
| echo "Expected main-ci-slack-alerts.yml to contain: ${expected}" >&2 | ||
| exit 1 | ||
| fi | ||
| } | ||
|
|
||
| assert_contains "- gh-readonly-queue/main/**" | ||
| assert_contains "contains(fromJSON('[\"push\",\"merge_group\"]'), github.event.workflow_run.event)" | ||
| assert_contains "checks: read" | ||
| assert_contains "pull-requests: read" | ||
| assert_contains 'LIVE_CANARY_SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}' | ||
| assert_contains 'if [[ "$HEAD_BRANCH" =~ ^gh-readonly-queue/main/pr-([0-9]+)- ]]; then' | ||
| assert_contains '"repos/${GITHUB_REPOSITORY}/pulls/${pr_number}"' | ||
| assert_contains '*Failed jobs / steps:*' | ||
| assert_contains '*Failure annotations (when available):*' | ||
|
|
||
| if ! grep -Fq -- '.github/workflows/(code_style|main-ci-slack-alerts)\.yml$' "$code_style_workflow"; then | ||
| echo "Expected code_style.yml to run CI alert workflow contract tests when the alert changes" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "main-ci-slack-alerts workflow contract passed" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Medium · Notifier behavior is not covered by the contract test
The test only searches the workflow text for several independent substrings. It never executes the embedded shell with mocked
ghandcurl, nor asserts the generated payload or selected webhook. Consequently, regressions such as reversing the push/merge-queue webhook routing, breaking the PR-ref parser, producing invalid Slack JSON, or introducing a shell runtime error can all pass while these strings remain somewhere in the file. Extract the notifier into a testable script or build a harness that runs the workflow command with representative push and merge-group fixtures and verifies API calls, payload escaping/bounds, routing, and failure behavior.