Repository navigation
ci: reduce Reborn PR long tails - #6914
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
🚅 Deployed to the ironclaw-pr-6914 environment in ironclaw-ci-preview
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR adds OVH sccache setup to the Reborn WebUI v2 smoke workflow and requires it in WS12 workflow contracts. It reorganizes Reborn crate test buckets, updates their partitioning tests, and lowers the PR-only changed-code coverage threshold from 90 to 85. ChangesReborn E2E sccache contract
Reborn crate test bucket reorganization
Changed-code coverage gate
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage ratchetReborn integration-tier coverageLine coverage (Reborn crates): 85.51% — 316988 / 370697 lines Per-crate breakdown (60 crates, lowest-covered first)
This table itself is informational and never gates the PR on its own — not the percentage, not the per-crate holes, not the 0-coverage callout. A separate coverage ratchet (dry-run until enforce=true; see tests/integration/coverage-floor.toml) can fail the build on specific configured floors. Exemptions (3 entry/entries excluded from the accounting above)
|
* ci: reduce Reborn PR long tails * ci: align changed-line coverage with global floor
Summary
adapters-miscReborn crate-test bucket intochannel-adapters,extension-operator, andarchitecture-miscwebui-v2-smokeMotivation
The measured
adapters-misclane spent 29m11s in its test step despite a 90.23% sccache hit rate. The slowest packages wereironclaw_telegram_extension(9m39s) andironclaw_operator(7m29s). Splitting independent package groups lets them execute in parallel. The WebUI smoke lane spent 6m07s in its Rust build and did not use the repository sccache setup.Change Type
CI performance and test sharding only. No product behavior changes.
Test Strategy
User behavior protected: Reborn PR CI still runs every crate assigned to the former adapter catch-all exactly once, and WebUI v2 smoke still builds and runs the same test commands.
Coverage level: CI contract/regression tests. No product unit, integration, E2E, live, or manual test tier is added because execution semantics and product code are unchanged.
Risk: Incorrect bucket assignment could omit or duplicate a crate; the exact-assignment regression test covers this. sccache service availability could affect cache performance, but the existing setup action degrades to local compilation rather than changing test behavior.
Verification
bash scripts/ci/test-reborn-crate-test-buckets.shbash scripts/ci/test-classify-test-scope.shpython3 scripts/ci/test_ws12_workflow_contracts.pypython3 scripts/ci/ws12_workflow_contracts.py.github/workflows/reborn-e2e.ymlwith Ruby YAMLgit diff --check origin/main...HEADSecurity Impact
No permissions, secrets, auth, or network policy changes. The workflow reuses the existing sccache action and secret interface.
Database Impact
None.
Rollback Plan
Revert this commit to restore the single
adapters-miscbucket and remove sccache setup from WebUI smoke.