Consolidate Reborn guidance and remove stale plans - #6670
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
🔎 IronLoop Review StatusHead: Current reviewers:
Reviewer summaries
Recent activity
Available commands
Run metadataAdmission: webhook accepted the request and IronLoop persisted reviewer state before this projection. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (121)
📝 WalkthroughSummary by CodeRabbit
WalkthroughRepository guidance, Reborn contracts, crate references, and extension documentation were updated to reflect ProductSurface ownership, channel-adapter boundaries, current crate locations, caller-first testing, and replacement of superseded architecture references. ChangesReborn guidance and workflow
ProductSurface contract alignment
Channel and extension documentation
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related issues
Suggested reviewers: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
scope: docs
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
![ironloopai[bot]](https://avatars.githubusercontent.com/in/4116490?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ IronLoop Review: reviewer
Review at a glance
| Verdict | Blocking | Notes | Inline | Head |
|---|---|---|---|---|
| ✅ Approved | 0 | 3 | 2 | 69d80b800f37 |
Head: 69d80b800f376a89c0f95aa1a7a976c43ce32991
Next: No reviewer action needed.
Run details
Status: Current
Needs human: no
Needs validation: no
Summary
No blocking runtime or security regressions found. Three non-blocking documentation/reference defects remain in the consolidation.
Findings
Blocking: 0 / Notes: 3
Non-blocking notes (3)
1. 💬 [LOW] Use the actual ChannelAdapter delivery method
Location: docs/reborn/how-to-port-channel-to-reborn.md:60
ChannelAdapter exposes deliver(...), not outbound(...). The new porting guide currently directs implementers to a method that does not exist; rename this step to ChannelAdapter::deliver.
2. 💬 [LOW] Telegram test comment still names a removed composition path
Location: tests/reborn_qa_connect_flows.rs:223-224
The updated comment still says the contract is pinned in crates/ironclaw_reborn_composition/src/telegram/, but that directory does not exist. Point readers to the live src/extension_host/channel_pairing* implementation and/or crates/ironclaw_telegram_extension instead.
3. 💬 [LOW] Architecture test comments retain references to the deleted filesystem ADR
Location: crates/ironclaw_architecture/tests/reborn_dependency_boundaries.rs:2931
Deleting docs/reborn/2026-05-14-universal-fs-dispatch.md leaves six stale references in this test (lines 2931, 3137, 3202, 3233, 3314, and 3377). Replace them with the current filesystem/storage-placement contracts or a path-independent description.
Developer follow-up
After fixing this feedback:
- Push the fix to this PR branch.
- Re-run this reviewer with
@ironloopai review --agent reviewerif you only changed this reviewer's findings. - Re-run all reviewers with
@ironloopai reviewwhen the fix may affect multiple areas.
| -> normalized inbound message | ||
| -> host admission and ProductSurface | ||
| -> projection/outbound selection | ||
| -> ChannelAdapter::outbound |
There was a problem hiding this comment.
ChannelAdapter has deliver(...), not outbound(...). Please use the real method name so this guide remains executable.
| /// provider=`telegram` auth continuation); that contract is pinned in | ||
| /// `crates/ironclaw_reborn_composition/src/telegram/` — see | ||
| /// `docs/reborn/contracts/telegram-v2.md`. | ||
| /// `docs/reborn/extension-runtime/overview.md` and the live Telegram adapter. |
There was a problem hiding this comment.
This revised comment still points at crates/ironclaw_reborn_composition/src/telegram/, which no longer exists. Point to the live extension-host pairing implementation and/or ironclaw_telegram_extension.
|
🚅 Deployed to the ironclaw-pr-6670 environment in ironclaw-ci-preview
|
github-actions
Bot
added
size: XL
Coverage ratchetReborn integration-tier coverageLine coverage (Reborn crates): 85.56% — 307133 / 358956 lines Per-crate breakdown (60 crates, lowest-covered first)
This table itself is informational and never gates the PR on its own — not the percentage, not the per-crate holes, not the 0-coverage callout. A separate coverage ratchet (dry-run until enforce=true; see tests/integration/coverage-floor.toml) can fail the build on specific configured floors. Exemptions (3 entry/entries excluded from the accounting above)
|
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
There was a problem hiding this comment.
✅ IronLoop Review: reviewer
Review at a glance
| Verdict | Blocking | Notes | Inline | Head |
|---|---|---|---|---|
| ✅ Approved | 0 | 3 | 2 | 7a1eceeb10c5 |
Head: 7a1eceeb10c58d86dc946786e82542ee5e10f9eb
Next: No reviewer action needed.
Run details
Status: Current
Needs human: no
Needs validation: no
Summary
No runtime or security regression found. Three non-blocking documentation-consistency issues should be cleaned up.
Findings
Blocking: 0 / Notes: 3
Non-blocking notes (3)
1. 💬 [MEDIUM] Current extension guidance still leaves the v2 adapter contract authoritative
Location: docs/reborn/contracts/extensions.md:106
docs/reborn/contracts/AGENTS.md treats this directory as authoritative, but this contract still says production manifests use v2 and directs readers to the removed ironclaw_product_adapter_registry test package. The newly current overview and every bundled manifest use v3/ChannelAdapter. Update these sections to the current paths and vocabulary, or explicitly mark this contract historical, so the consolidation does not leave contradictory guidance.
2. 💬 [LOW] Channel porting guide names a nonexistent outbound API
Location: docs/reborn/how-to-port-channel-to-reborn.md:60
ChannelAdapter exposes deliver(...), not outbound(...). The new flow sends implementers to a nonexistent API and obscures the delivery boundary; change this step to ChannelAdapter::deliver.
3. 💬 [LOW] Deleted guidance remains referenced in architecture test comments
Location: crates/ironclaw_architecture/tests/reborn_dependency_boundaries.rs:2931
Six comments in this test still cite the deleted 2026-05-14-universal-fs-dispatch document (including lines 2931, 3137, 3202, 3233, 3314, and 3377). A separate composition test comment still cites deleted tool-evidence.md. Replace these with the current filesystem/storage and capability-access contracts so the stated stale-reference cleanup is complete.
Developer follow-up
After fixing this feedback:
- Push the fix to this PR branch.
- Re-run this reviewer with
@ironloopai review --agent reviewerif you only changed this reviewer's findings. - Re-run all reviewers with
@ironloopai reviewwhen the fix may affect multiple areas.
|
|
||
| **Status:** Approved design. | ||
| **Companions:** `implementation.md` (what changes, where), `checklist.md` (acceptance). | ||
| **Status:** Current extension-runtime model. |
There was a problem hiding this comment.
docs/reborn/contracts/AGENTS.md still treats contracts/extensions.md as authoritative, but it says production manifests use v2 and refers to the removed product-adapter registry. Update or mark that contract historical so this new current overview is not contradicted.
| -> normalized inbound message | ||
| -> host admission and ProductSurface | ||
| -> projection/outbound selection | ||
| -> ChannelAdapter::outbound |
There was a problem hiding this comment.
ChannelAdapter has deliver(...), not outbound(...); please name deliver here so the porting flow matches the live contract.
This branch was successfully deployed
1 participant
Summary
Change Type
Linked Issue
None.
Validation
git diff HEAD^ --checkcargo fmt --all -- --check: Not run; no Rust behavior or formatting changed.cargo clippy --all --benches --tests --examples --all-features -- -D warnings: Not run; no Rust behavior changed.review-prorpr-shepherd --fix: Not run; no code behavior changed.Test Strategy
User behavior: Agents now receive one current Reborn architecture vocabulary and are less likely to follow deleted plans or obsolete integration paths.
Risk areas:
Tests added or updated:
What the tests prove:
git diff HEAD^ --checkpasses and repository-wide scans find no references to deleted Reborn plans or contracts.Commands run:
git diff HEAD^ --checkrg -n 'docs/reborn/(20[0-9]{2}-|contracts/(telegram-v2|product-adapters)\.md)' . --glob '!target/**' --glob '!.git/**'Security Impact
None.
Reborn Trust-Boundary Checklist
N/A: no trust-bearing runtime or security behavior changed.
Database Impact
None.
Blast Radius
Documentation, agent guidance, comments, and test/script references only. No production behavior changes.
Rollback Plan
Revert commit
69d80b800.Review Follow-Through
The superseded extension implementation and checklist documents remain available as explicitly labeled historical migration records.
Review track: A (docs/tests/chore)