Repository navigation
Default cargo run to WebUI serve #6663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| [workspace] | ||
| members = [".", "crates/ironclaw_common", "crates/ironclaw_observability", "crates/ironclaw_host_api", "crates/ironclaw_host_ingress", "crates/ironclaw_filesystem", "crates/ironclaw_attachments", "crates/ironclaw_extractors", "crates/ironclaw_memory", "crates/ironclaw_memory_native", "crates/ironclaw_memory_mem0", "crates/ironclaw_events", "crates/ironclaw_event_projections", "crates/ironclaw_event_streams", "crates/ironclaw_reborn_event_store", "crates/ironclaw_extensions", "crates/ironclaw_extension_host", "crates/ironclaw_processes", "crates/ironclaw_dispatcher", "crates/ironclaw_scripts", "crates/ironclaw_process_sandbox", "crates/ironclaw_mcp", "crates/ironclaw_wasm", "crates/ironclaw_wasm_limiter", "crates/ironclaw_capabilities", "crates/ironclaw_secrets", "crates/ironclaw_network", "crates/ironclaw_host_runtime", "crates/ironclaw_runtime_policy", "crates/ironclaw_authorization", "crates/ironclaw_run_state", "crates/ironclaw_approvals", "crates/ironclaw_resources", "crates/ironclaw_auth", "crates/ironclaw_trust", "crates/ironclaw_turns", "crates/ironclaw_agent_loop", "crates/ironclaw_threads", "crates/ironclaw_prompt_envelope", "crates/ironclaw_hooks", "crates/ironclaw_loop_host", "crates/ironclaw_runner", "crates/ironclaw_reborn_config", "crates/ironclaw_operator", "crates/ironclaw_reborn_composition", "crates/ironclaw_reborn_identity", "crates/ironclaw_first_party_extensions", "crates/ironclaw_reborn_cli", "crates/ironclaw_reborn_traces", "crates/ironclaw_webui", "crates/ironclaw_reborn_openai_compat", "crates/ironclaw_conversations", "crates/ironclaw_product", "crates/ironclaw_telegram_extension", "crates/ironclaw_telegram_v2_adapter", "crates/ironclaw_slack_extension", "crates/ironclaw_outbound", "crates/ironclaw_triggers", "crates/ironclaw_projects", "crates/ironclaw_architecture", "crates/ironclaw_safety", "crates/ironclaw_skills", "crates/ironclaw_llm", "crates/ironclaw_embeddings", "tools/ironclaw_stress"] | ||
| default-members = ["crates/ironclaw_reborn_cli"] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== candidate files =="
git ls-files | rg '(^|/)(Cargo\.toml|CLAUDE\.md|AGENTS\.md|\.claude/.*rules.*|README\.md)$|\.cargo/config.toml$' | sed -n '1,200p'
echo
echo "== Cargo.toml relevant =="
if [ -f Cargo.toml ]; then
cat -n Cargo.toml | sed -n '1,80p'
fi
echo
echo "== rule mentions =="
for f in CLAUDE.md AGENTS.md; do
if [ -f "$f" ]; then
echo "-- $f --"
rg -n "workspace|workspace-wide|CLIP|Clippy|cargo clippy|default-members|validation|zero-warning|Reborn" "$f" || true
fi
done
if [ -d .claude/rules ]; then
for f in .claude/rules/*; do
echo "-- $f --"
rg -n "workspace|workspace-wide|CLIP|Clippy|cargo clippy|default-members|validation|zero-warning|Reborn" "$f" || true
done
fi
echo
echo "== workspace member count and crate features summary =="
python3 - <<'PY'
import tomllib
from pathlib import Path
cargo = Path('Cargo.toml')
if not cargo.exists():
raise SystemExit(1)
data = tomllib.loads(cargo.read_text())
ws=data.get('workspace',{})
print('members=', ws.get('members'))
print('default-members=', ws.get('default-members'))
print('package=', data.get('package',{}).get('name'))
PY
echo
echo "== deterministic cargo default-members selector probe if cargo/config available =="
if command -v cargo >/dev/null 2>&1; then
tmp="$(mktemp -d)"
mkdir -p "$tmp/proj" "$tmp/proj/a" "$tmp/proj/b"
cat > "$tmp/proj/Cargo.toml" <<'EOF'
[workspace]
members = ["a", "b"]
default-members = ["a"]
EOF
mkdir -p "$tmp/proj/a/src" "$tmp/proj/b/src"
cat > "$tmp/proj/a/src/lib.rs" <<'EOF'
pub fn add(a: i32, b: i32) -> i32 { a + b }
EOF
cat > "$tmp/proj/b/src/lib.rs" <<'EOF'
pub fn sub(x: i32, y: i32) -> i32 { x - y }
EOF
mkdir -p "$tmp/proj/.cargo"
echo 'cargo-default = true' > "$tmp/proj/.cargo/config.toml"
(cd "$tmp/proj" && cargo metadata --format-version 1 --offline >/tmp/cargo_metadata_default.json)
python3 - <<'PY'
import json
from pathlib import Path
data=json.loads(Path('/tmp/cargo_metadata_default.json').read_text())
print("workspace=.", data["workspace_root"])
print("packages=", sorted(p.get("name") for p in data["packages"]))
PY
else
echo "cargo not available"
fiRepository: nearai/ironclaw Length of output: 24141 Disable default-members unless it is needed for a scoped run command.
🤖 Prompt for AI AgentsSource: Coding guidelines |
||
| exclude = [ | ||
| "crates/ironclaw_silk_decoder", | ||
| "fuzz", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default-membersapplies to every package-unspecified Cargo command, not justcargo run. This switchescargo test --locked --libto the bin-only CLI and makes rootreborn_*test commands in CI select a package that does not own those targets. Please preserve or explicitly set the root integration-test package for those callers.