fix(tests): replace hardcoded /tmp paths with tempdir + add 300 unit tests

[ilblackdragon]

Summary

• Fix failing test e2e_metrics_test::test_metrics_collected_from_tool_trace caused by a path mismatch: setup_test_dir() created /tmp/ironclaw_metrics_test but the fixture wrote to /tmp/ironclaw_e2e_test/hello.txt
• Add LlmTrace::replace_paths() to substitute hardcoded fixture paths with dynamic tempfile::tempdir() paths at runtime
• Convert all 12 test files from hardcoded /tmp/ironclaw_* paths to tempfile::tempdir(), making tests isolated, parallel-safe, and leaving no debris
• Add 300+ unit tests across 20 modules (config, context, evaluation, extensions, LLM, secrets, tools/builder, tools/mcp) for coverage push

Test plan

• cargo fmt clean
• cargo clippy --all --benches --tests --examples --all-features zero warnings
• test_metrics_collected_from_tool_trace passes (was failing)
• All 67 modified e2e/support tests pass
• All 2385 library unit tests pass

🤖 Generated with Claude Code

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[Copilot]

Pull request overview

This PR fixes a failing e2e test caused by a path mismatch between setup_test_dir() and a fixture, introduces LlmTrace::replace_paths() to dynamically substitute hardcoded fixture paths with tempfile::tempdir() paths at runtime, converts all 12 test files from hardcoded /tmp/ironclaw_* paths to isolated temp directories, and adds 300+ unit tests across 20 modules for improved coverage.

Changes:

• Added LlmTrace::replace_paths() and replace_in_json_value() helper for recursive JSON path substitution, enabling test fixtures to work with dynamic temp directories
• Converted all e2e test files from hardcoded /tmp/ironclaw_* paths to tempfile::tempdir(), removing CleanupGuard usage and making tests parallel-safe
• Added 300+ unit tests across config, context, evaluation, extensions, LLM, secrets, tools/builder, and tools/mcp modules, plus a detailed COVERAGE_PLAN.md roadmap

Reviewed changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/support/trace_llm.rs	Added replace_paths() method and replace_in_json_value() recursive helper
tests/e2e_trace_file_tools.rs	Converted to tempdir, removed CleanupGuard
tests/e2e_metrics_test.rs	Fixed the originally failing test by using tempdir + replace_paths
tests/e2e_spot_checks.rs	Converted two tests to tempdir
tests/e2e_advanced_traces.rs	Converted four tests to tempdir
tests/e2e_tool_coverage.rs	Converted two tests to tempdir
tests/e2e_worker_coverage.rs	Simplified fixture patching to use replace_paths
tests/support_unit_tests.rs	CleanupGuard tests now use tempdir internally
src/config/mod.rs	Replaced hardcoded /tmp with std::env::temp_dir() in test defaults
src/config/llm.rs	Replaced hardcoded /tmp with std::env::temp_dir() in test defaults
src/config/channels.rs	Added 162 lines of unit tests for channel config types
src/config/tunnel.rs	Added 215 lines of unit tests for tunnel config
src/config/sandbox.rs	Added 204 lines of unit tests for sandbox config
src/tools/builtin/extension_tools.rs	Replaced hardcoded /tmp with std::env::temp_dir()
src/tools/builder/validation.rs	Added 163 lines of WASM validation tests
src/tools/builder/templates.rs	Added 163 lines of template engine tests
src/tools/builder/core.rs	Added 384 lines of builder core type tests
src/tools/mcp/session.rs	Added 108 lines of MCP session manager tests
src/tools/mcp/protocol.rs	Added 279 lines of MCP protocol tests
src/tools/mcp/client.rs	Added 161 lines of MCP client tests
src/tools/mcp/auth.rs	Added 310 lines of MCP auth tests
src/secrets/types.rs	Added 226 lines of secrets type tests
src/secrets/crypto.rs	Added 108 lines of crypto tests
src/llm/session.rs	Added 154 lines of session manager tests
src/llm/nearai_chat.rs	Added 599 lines of NEAR AI chat tests
src/extensions/mod.rs	Added 418 lines of extension type tests
src/extensions/discovery.rs	Added 180 lines of discovery tests
src/evaluation/success.rs	Added 257 lines of evaluation tests
src/evaluation/metrics.rs	Added 220 lines of metrics tests
src/context/memory.rs	Added 276 lines of memory tests
src/context/manager.rs	Added 391 lines of context manager tests
src/setup/wizard.rs	Updated test to use dynamic path
COVERAGE_PLAN.md	Added comprehensive coverage plan document

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.